From: John Garry via iommu <iommu@lists.linux-foundation.org>
To: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>,
<matthew.d.roper@intel.com>, <baolu.lu@linux.intel.com>,
<dri-devel@lists.freedesktop.org>
Cc: iommu@lists.linux-foundation.org, hch@lst.de
Subject: Re: [PATCH v2] iommu/core: Remove comment reference to iommu_dev_has_feature
Date: Mon, 7 Feb 2022 10:51:45 +0000 [thread overview]
Message-ID: <37dcfcad-ff08-09dd-b35c-a3f90fcaa37f@huawei.com> (raw)
In-Reply-To: <20220207032322.16667-1-akeem.g.abodunrin@intel.com>
On 07/02/2022 03:23, Akeem G Abodunrin wrote:
> iommu_dev_has_feature() api has been removed by the commit 262948f8ba573
> ("iommu: Delete iommu_dev_has_feature()") - So this patch removes comment
> about the api to avoid any confusion.
>
> Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.garry@huawei.com>
BTW, It looks like we can get rid of iommu_ops.dev_has_feat also.
It does not seem to be called, while arm-smmu-v3 driver does provide a
callback.
> ---
> include/linux/iommu.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index de0c57a567c8..bea054f2bd4d 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -153,8 +153,7 @@ struct iommu_resv_region {
> * supported, this feature must be enabled before and
> * disabled after %IOMMU_DEV_FEAT_SVA.
> *
> - * Device drivers query whether a feature is supported using
> - * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature().
> + * Device drivers enable the feature via iommu_dev_enable_feature().
> */
> enum iommu_dev_features {
> IOMMU_DEV_FEAT_AUX,
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2022-02-07 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 3:23 [PATCH v2] iommu/core: Remove comment reference to iommu_dev_has_feature Akeem G Abodunrin
2022-02-07 10:51 ` John Garry via iommu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37dcfcad-ff08-09dd-b35c-a3f90fcaa37f@huawei.com \
--to=iommu@lists.linux-foundation.org \
--cc=akeem.g.abodunrin@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox