* [PATCH v2] iommu/core: Remove comment reference to iommu_dev_has_feature
@ 2022-02-07 3:23 Akeem G Abodunrin
2022-02-07 10:51 ` John Garry via iommu
0 siblings, 1 reply; 2+ messages in thread
From: Akeem G Abodunrin @ 2022-02-07 3:23 UTC (permalink / raw)
To: akeem.g.abodunrin, matthew.d.roper, baolu.lu, dri-devel; +Cc: iommu, hch
iommu_dev_has_feature() api has been removed by the commit 262948f8ba573
("iommu: Delete iommu_dev_has_feature()") - So this patch removes comment
about the api to avoid any confusion.
Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
include/linux/iommu.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index de0c57a567c8..bea054f2bd4d 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -153,8 +153,7 @@ struct iommu_resv_region {
* supported, this feature must be enabled before and
* disabled after %IOMMU_DEV_FEAT_SVA.
*
- * Device drivers query whether a feature is supported using
- * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature().
+ * Device drivers enable the feature via iommu_dev_enable_feature().
*/
enum iommu_dev_features {
IOMMU_DEV_FEAT_AUX,
--
2.21.3
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iommu/core: Remove comment reference to iommu_dev_has_feature
2022-02-07 3:23 [PATCH v2] iommu/core: Remove comment reference to iommu_dev_has_feature Akeem G Abodunrin
@ 2022-02-07 10:51 ` John Garry via iommu
0 siblings, 0 replies; 2+ messages in thread
From: John Garry via iommu @ 2022-02-07 10:51 UTC (permalink / raw)
To: Akeem G Abodunrin, matthew.d.roper, baolu.lu, dri-devel; +Cc: iommu, hch
On 07/02/2022 03:23, Akeem G Abodunrin wrote:
> iommu_dev_has_feature() api has been removed by the commit 262948f8ba573
> ("iommu: Delete iommu_dev_has_feature()") - So this patch removes comment
> about the api to avoid any confusion.
>
> Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.garry@huawei.com>
BTW, It looks like we can get rid of iommu_ops.dev_has_feat also.
It does not seem to be called, while arm-smmu-v3 driver does provide a
callback.
> ---
> include/linux/iommu.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index de0c57a567c8..bea054f2bd4d 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -153,8 +153,7 @@ struct iommu_resv_region {
> * supported, this feature must be enabled before and
> * disabled after %IOMMU_DEV_FEAT_SVA.
> *
> - * Device drivers query whether a feature is supported using
> - * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature().
> + * Device drivers enable the feature via iommu_dev_enable_feature().
> */
> enum iommu_dev_features {
> IOMMU_DEV_FEAT_AUX,
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-07 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-07 3:23 [PATCH v2] iommu/core: Remove comment reference to iommu_dev_has_feature Akeem G Abodunrin
2022-02-07 10:51 ` John Garry via iommu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox