Linux IOMMU Development
 help / color / mirror / Atom feed
* Question about moving code in amd-iommu.c
@ 2015-01-01  5:06 nick
  0 siblings, 0 replies; only message in thread
From: nick @ 2015-01-01  5:06 UTC (permalink / raw)
  To: joro-zLv9SwRftAIdnm+yROfE0A
  Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Greetings Joerg,
I assume you wrote this code as the maintainer : 
 /* FIXME: Move this to PCI code */
 #define PCI_PRI_TLP_OFF         (1 << 15)

static bool pci_pri_tlp_required(struct pci_dev *pdev)
{
        u16 status;
        int pos;

        pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_PRI);
        if (!pos)
               return false;

        pci_read_config_word(pdev, pos + PCI_PRI_STATUS, &status);

        return (status & PCI_PRI_TLP_OFF) ? true : false;
}
I am wondering due to the fix me being rather value as to where to move this code.
Have a Great New Year's,
Nick

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-01-01  5:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-01  5:06 Question about moving code in amd-iommu.c nick

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox