[PATCH] intel_irq_remapping: fix a comment error

[PATCH] intel_irq_remapping: fix a comment error

[xiaofeng.yan]

change tabke to take.

Signed-off-by: xiaofeng.yan <yanxiaofeng@inspur.com>
---
 drivers/iommu/intel_irq_remapping.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index 5709ae9..d59f82d 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -46,7 +46,7 @@ static struct hpet_scope ir_hpet[MAX_HPET_TBS];
  *	->iommu->register_lock
  * Note:
  * intel_irq_remap_ops.{supported,prepare,enable,disable,reenable} are called
- * in single-threaded environment with interrupt disabled, so no need to tabke
+ * in single-threaded environment with interrupt disabled, so no need to take
  * the dmar_global_lock.
  */
 static DEFINE_RAW_SPINLOCK(irq_2_ir_lock);
@@ -185,6 +185,7 @@ static int modify_irte(int irq, struct irte *irte_modified)
 		return -1;
 
 	raw_spin_lock_irqsave(&irq_2_ir_lock, flags);
+	while(1):
 
 	iommu = irq_iommu->iommu;
 
-- 
1.9.1

Re: [PATCH] intel_irq_remapping: fix a comment error

[Jiang Liu]

On 2015/6/3 16:20, xiaofeng.yan wrote:
> change tabke to take.
> 
> Signed-off-by: xiaofeng.yan <yanxiaofeng-6gUaA8visnnQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/iommu/intel_irq_remapping.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 5709ae9..d59f82d 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -46,7 +46,7 @@ static struct hpet_scope ir_hpet[MAX_HPET_TBS];
>   *	->iommu->register_lock
>   * Note:
>   * intel_irq_remap_ops.{supported,prepare,enable,disable,reenable} are called
> - * in single-threaded environment with interrupt disabled, so no need to tabke
> + * in single-threaded environment with interrupt disabled, so no need to take
>   * the dmar_global_lock.
>   */
>  static DEFINE_RAW_SPINLOCK(irq_2_ir_lock);
> @@ -185,6 +185,7 @@ static int modify_irte(int irq, struct irte *irte_modified)
>  		return -1;
>  
>  	raw_spin_lock_irqsave(&irq_2_ir_lock, flags);
> +	while(1):
Hi Xiaofeng,
	Seems above change be removed.
Thanks!
Gerry

>  
>  	iommu = irq_iommu->iommu;
>  
> 

Re: [PATCH] intel_irq_remapping: fix a comment error

[yanxiaofeng]

[-- Attachment #1.1: Type: text/plain, Size: 1399 bytes --]



在 2015年06月03日 16:25, Jiang Liu 写道:
> On 2015/6/3 16:20, xiaofeng.yan wrote:
>> change tabke to take.
>>
>> Signed-off-by: xiaofeng.yan <yanxiaofeng-6gUaA8visnnQT0dZR+AlfA@public.gmane.org>
>> ---
>>   drivers/iommu/intel_irq_remapping.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
>> index 5709ae9..d59f82d 100644
>> --- a/drivers/iommu/intel_irq_remapping.c
>> +++ b/drivers/iommu/intel_irq_remapping.c
>> @@ -46,7 +46,7 @@ static struct hpet_scope ir_hpet[MAX_HPET_TBS];
>>    *	->iommu->register_lock
>>    * Note:
>>    * intel_irq_remap_ops.{supported,prepare,enable,disable,reenable} are called
>> - * in single-threaded environment with interrupt disabled, so no need to tabke
>> + * in single-threaded environment with interrupt disabled, so no need to take
>>    * the dmar_global_lock.
>>    */
>>   static DEFINE_RAW_SPINLOCK(irq_2_ir_lock);
>> @@ -185,6 +185,7 @@ static int modify_irte(int irq, struct irte *irte_modified)
>>   		return -1;
>>   
>>   	raw_spin_lock_irqsave(&irq_2_ir_lock, flags);
>> +	while(1):
> Hi Xiaofeng,
> 	Seems above change be removed.
Yes, Thank you for your correction.
I will send correctional patch.

Thanks
Yan
> Thanks!
> Gerry
>
>>   
>>   	iommu = irq_iommu->iommu;
>>   
>>
> .
>


[-- Attachment #1.2: Type: text/html, Size: 2245 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]