Linux IOMMU Development
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Li RongQing <lirongqing@baidu.com>,
	joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH] iommu: Downgrade print level for iommu group information
Date: Tue, 26 Nov 2024 11:49:06 +0000	[thread overview]
Message-ID: <84cb9155-4793-45f9-bb67-6926e103dc84@arm.com> (raw)
In-Reply-To: <20241126072339.25714-1-lirongqing@baidu.com>

On 26/11/2024 7:23 am, Li RongQing wrote:
> This per device log is becoming longer with more and more PCI devices
> in system, which slows down the boot process due to the serializing
> nature of printk().
> 
> Downgrade dev_info() to dev_dbg() so it is still accessible for debug
> purposes.

Previously discussed 4 and a half years ago:

https://lore.kernel.org/linux-iommu/20200302154426.GC6540@8bytes.org/

Also, given that the iommu_probe_device() path is inherently serialised 
anyway, if logging a message from there significantly slows down your 
boot process, how slow is your console device?

Thanks,
Robin.

> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
>   drivers/iommu/iommu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 83c8e61..a16f944 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -1193,7 +1193,7 @@ static struct group_device *iommu_group_alloc_device(struct iommu_group *group,
>   
>   	trace_add_device_to_group(group->id, dev);
>   
> -	dev_info(dev, "Adding to iommu group %d\n", group->id);
> +	dev_dbg(dev, "Adding to iommu group %d\n", group->id);
>   
>   	return device;
>   

  parent reply	other threads:[~2024-11-26 11:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26  7:23 [PATCH] iommu: Downgrade print level for iommu group information Li RongQing
2024-11-26 10:25 ` Pranjal Shrivastava
2024-11-26 10:47   ` 答复: [????] " Li,Rongqing
2024-11-26 11:49 ` Robin Murphy [this message]
2024-11-26 12:09   ` 答复: [外部邮件] " Li,Rongqing
2024-11-27 10:16     ` Pranjal Shrivastava
2024-11-27 11:32       ` 答复: " Li,Rongqing
2024-11-29  8:21         ` Li,Rongqing
2024-11-27 12:37       ` Robin Murphy
2024-11-27 20:56         ` Pranjal Shrivastava
2024-11-27 12:12     ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84cb9155-4793-45f9-bb67-6926e103dc84@arm.com \
    --to=robin.murphy@arm.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=lirongqing@baidu.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox