答复: 答复: [外部邮件] Re: [PATCH] iommu: Downgrade print level for iommu group information

["Li,Rongqing" <lirongqing@baidu.com>]

> 
> I free this log is useless; since iommu_group_alloc_device only allocates device
> and sysfs, not attach group domain currently.
> If failed, " Failed to add to iommu group " will be printed, it is more important to
> notice user.
> 

After this patch(iommu: Split iommu_group_add_device()), should this log be moved to iommu_group_add_device and __iommu_probe_device ? they are adding device to iommu group, not be in iommu_group_alloc_device which only allocate resource 


diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 83c8e61..c33ff0e 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -581,6 +581,9 @@ static int __iommu_probe_device(struct device *dev, struct list_head *group_list

        mutex_unlock(&group->mutex);

+       trace_add_device_to_group(group->id, dev);
+       dev_info(dev, "Adding to iommu group %d\n", group->id);
+
        return 0;

 err_remove_gdev:
@@ -1191,9 +1194,6 @@ static struct group_device *iommu_group_alloc_device(struct iommu_group *group,
                goto err_free_name;
        }

-       trace_add_device_to_group(group->id, dev);
-
-       dev_info(dev, "Adding to iommu group %d\n", group->id);

        return device;

@@ -1229,6 +1229,10 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev)
        mutex_lock(&group->mutex);
        list_add_tail(&gdev->list, &group->devices);
        mutex_unlock(&group->mutex);
+
+       trace_add_device_to_group(group->id, dev);
+       dev_info(dev, "Adding to iommu group %d\n", group->id);
+
        return 0;
 }
 EXPORT_SYMBOL_GPL(iommu_group_add_device);