* [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root
[not found] <20201105165814.29233-1-wei.liu@kernel.org>
@ 2020-11-05 16:58 ` Wei Liu
2020-11-12 15:27 ` Vitaly Kuznetsov
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2020-11-05 16:58 UTC (permalink / raw)
To: Linux on Hyper-V List
Cc: K. Y. Srinivasan, Wei Liu, Joerg Roedel, Stephen Hemminger,
Haiyang Zhang, Linux Kernel List, Michael Kelley,
open list:IOMMU DRIVERS, Nuno Das Neves, Sunil Muthuswamy,
virtualization, Vineeth Pillai
The IOMMU code needs more work. We're sure for now the IRQ remapping
hooks are not applicable when Linux is the root.
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Acked-by: Joerg Roedel <jroedel@suse.de>
---
drivers/iommu/hyperv-iommu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
index e09e2d734c57..8d3ce3add57d 100644
--- a/drivers/iommu/hyperv-iommu.c
+++ b/drivers/iommu/hyperv-iommu.c
@@ -20,6 +20,7 @@
#include <asm/io_apic.h>
#include <asm/irq_remapping.h>
#include <asm/hypervisor.h>
+#include <asm/mshyperv.h>
#include "irq_remapping.h"
@@ -143,7 +144,7 @@ static int __init hyperv_prepare_irq_remapping(void)
int i;
if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
- !x2apic_supported())
+ !x2apic_supported() || hv_root_partition)
return -ENODEV;
fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
--
2.20.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root
2020-11-05 16:58 ` [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root Wei Liu
@ 2020-11-12 15:27 ` Vitaly Kuznetsov
2020-11-13 14:53 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Kuznetsov @ 2020-11-12 15:27 UTC (permalink / raw)
To: Wei Liu, Linux on Hyper-V List
Cc: K. Y. Srinivasan, Wei Liu, Joerg Roedel, Stephen Hemminger,
Haiyang Zhang, Linux Kernel List, Michael Kelley,
open list:IOMMU DRIVERS, Nuno Das Neves, Sunil Muthuswamy,
virtualization, Vineeth Pillai
Wei Liu <wei.liu@kernel.org> writes:
> The IOMMU code needs more work. We're sure for now the IRQ remapping
> hooks are not applicable when Linux is the root.
Super-nitpick: I would suggest we always say 'root partition' as 'root'
has a 'slightly different' meaning in Linux and this commit message may
sound confusing to an unprepared reader.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> Acked-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/hyperv-iommu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> index e09e2d734c57..8d3ce3add57d 100644
> --- a/drivers/iommu/hyperv-iommu.c
> +++ b/drivers/iommu/hyperv-iommu.c
> @@ -20,6 +20,7 @@
> #include <asm/io_apic.h>
> #include <asm/irq_remapping.h>
> #include <asm/hypervisor.h>
> +#include <asm/mshyperv.h>
>
> #include "irq_remapping.h"
>
> @@ -143,7 +144,7 @@ static int __init hyperv_prepare_irq_remapping(void)
> int i;
>
> if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
> - !x2apic_supported())
> + !x2apic_supported() || hv_root_partition)
> return -ENODEV;
>
> fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root
2020-11-12 15:27 ` Vitaly Kuznetsov
@ 2020-11-13 14:53 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2020-11-13 14:53 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: K. Y. Srinivasan, Wei Liu, Joerg Roedel, Stephen Hemminger,
Linux on Hyper-V List, Haiyang Zhang, Linux Kernel List,
Michael Kelley, open list:IOMMU DRIVERS, Nuno Das Neves,
Sunil Muthuswamy, virtualization, Vineeth Pillai
On Thu, Nov 12, 2020 at 04:27:14PM +0100, Vitaly Kuznetsov wrote:
> Wei Liu <wei.liu@kernel.org> writes:
>
> > The IOMMU code needs more work. We're sure for now the IRQ remapping
> > hooks are not applicable when Linux is the root.
>
> Super-nitpick: I would suggest we always say 'root partition' as 'root'
> has a 'slightly different' meaning in Linux and this commit message may
> sound confusing to an unprepared reader.
Fixed.
>
> >
> > Signed-off-by: Wei Liu <wei.liu@kernel.org>
> > Acked-by: Joerg Roedel <jroedel@suse.de>
> > ---
> > drivers/iommu/hyperv-iommu.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> > index e09e2d734c57..8d3ce3add57d 100644
> > --- a/drivers/iommu/hyperv-iommu.c
> > +++ b/drivers/iommu/hyperv-iommu.c
> > @@ -20,6 +20,7 @@
> > #include <asm/io_apic.h>
> > #include <asm/irq_remapping.h>
> > #include <asm/hypervisor.h>
> > +#include <asm/mshyperv.h>
> >
> > #include "irq_remapping.h"
> >
> > @@ -143,7 +144,7 @@ static int __init hyperv_prepare_irq_remapping(void)
> > int i;
> >
> > if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
> > - !x2apic_supported())
> > + !x2apic_supported() || hv_root_partition)
> > return -ENODEV;
> >
> > fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Thanks.
Wei.
>
> --
> Vitaly
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-13 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201105165814.29233-1-wei.liu@kernel.org>
2020-11-05 16:58 ` [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root Wei Liu
2020-11-12 15:27 ` Vitaly Kuznetsov
2020-11-13 14:53 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox