From: Logan Gunthorpe <logang@deltatee.com>
To: Robin Murphy <robin.murphy@arm.com>, hch@infradead.org
Cc: m.szyprowski@samsung.com, iommu@lists.linux.dev,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-mapping: Name SG DMA flag helpers consistently
Date: Tue, 30 May 2023 11:23:12 -0600 [thread overview]
Message-ID: <8a411404-a2fc-694c-c41e-5d7efba38472@deltatee.com> (raw)
In-Reply-To: <fa2eca2862c7ffc41b50337abffb2dfd2864d3ea.1685036694.git.robin.murphy@arm.com>
On 2023-05-25 11:46, Robin Murphy wrote:
> sg_is_dma_bus_address() is inconsistent with the naming pattern of its
> corresponding setters and its own kerneldoc, so take the majority vote
> and rename it sg_dma_is_bus_address() (and fix up the missing
> underscores in the kerneldoc too). This gives us a nice clear pattern
> where SG DMA flags are SG_DMA_<NAME>, and the helpers for acting on them
> are sg_dma_<action>_<name>().
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Looks good to me. Thanks.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
prev parent reply other threads:[~2023-05-30 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 17:46 [PATCH] dma-mapping: Name SG DMA flag helpers consistently Robin Murphy
2023-05-26 6:42 ` Christoph Hellwig
2023-05-30 17:12 ` Jerry Snitselaar
2023-05-30 17:23 ` Logan Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a411404-a2fc-694c-c41e-5d7efba38472@deltatee.com \
--to=logang@deltatee.com \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox