Re: [PATCH v9 01/21] iommu: Clear handle->domain in detach

[Yi Liu <yi.l.liu@intel.com>]

On 2025/3/18 19:46, Jason Gunthorpe wrote:
> On Thu, Mar 13, 2025 at 05:35:12AM -0700, Yi Liu wrote:
>> The iommu core sets the handle->domain in attach/replace. To be completed,
>> it should clear handle->domain in detach as well to avoid potential side
>> effect if caller reuses a handle.
>>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>>   drivers/iommu/iommu.c | 18 ++++++++++++++++--
>>   1 file changed, 16 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> 
>> +	entry = xa_erase(&group->pasid_array, pasid);
>> +	WARN_ON(!entry);
>> +	iommu_pasid_array_entry_clear_handle(entry);
> 
> Though if you have to respin it I'd probably put the WARN_ON inside
> iommu_pasid_array_entry_clear_handle()
> 
> if (WARN_ON(!entry))
>     return;
> 
> Then it doesn't oops the kernel immediately after.

yes. I think at least one more version given the remarks in later patches.

-- 
Regards,
Yi Liu