From: Robin Murphy <robin.murphy@arm.com>
To: Matthias Kaehlcke <mka@chromium.org>,
Sharat Masetty <smasetty@codeaurora.org>
Cc: devicetree@vger.kernel.org, will@kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
bjorn.andersson@linaro.org, iommu@lists.linux-foundation.org,
dri-devel@freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks
Date: Wed, 26 Feb 2020 13:55:14 +0000 [thread overview]
Message-ID: <9cb8551f-becd-d84e-e0ce-43f13b84ad89@arm.com> (raw)
In-Reply-To: <20200220210242.GC24720@google.com>
[ /me fires off MAINTAINERS patch... ]
On 20/02/2020 9:02 pm, Matthias Kaehlcke wrote:
> On Thu, Feb 20, 2020 at 01:42:22PM +0530, Sharat Masetty wrote:
>> This patch adds a clock definition needed for powering on the GPU TBUs
>> and the GPU TCU.
>>
>> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> index 6515dbe..235c0df 100644
>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> @@ -28,6 +28,7 @@ properties:
>> - enum:
>> - qcom,msm8996-smmu-v2
>> - qcom,msm8998-smmu-v2
>> + - qcom,sc7180-smmu-v2
>
> The addition of the compatible string isn't (directly) related with $subject,
> this should be done in a separate patch.
...or the patch should just be accurately described as "add support for
new variant X, which requires an additional clock Y".
And speaking of which, can anyone clarify how "TCU and TBU core clock"
manages to abbreviate to "mem_iface_clk"? I would have naively assumed
something like "core" would be most logical.
Robin.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
parent reply other threads:[~2020-02-26 13:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200220210242.GC24720@google.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cb8551f-becd-d84e-e0ce-43f13b84ad89@arm.com \
--to=robin.murphy@arm.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=smasetty@codeaurora.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox