Linux IOMMU Development
 help / color / mirror / Atom feed
From: Pranjal Shrivastava <praan@google.com>
To: Li RongQing <lirongqing@baidu.com>
Cc: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
	iommu@lists.linux.dev, baolu.lu@linux.intel.com,
	vasant.hegde@amd.com
Subject: Re: [PATCH][v2] iommu: move the adding group info to proper place
Date: Tue, 7 Jan 2025 04:00:49 +0000	[thread overview]
Message-ID: <Z3ym8Z73RcT_f8OZ@google.com> (raw)
In-Reply-To: <20250107033558.41135-1-lirongqing@baidu.com>

On Tue, Jan 07, 2025 at 11:35:58AM +0800, Li RongQing wrote:
> After commit fa0828036488 ("iommu: Split iommu_group_add_device()"), the
> adding group information is left in iommu_group_alloc_device, but which
> only allocate group device, not attach the device to iommu group;
> 
> so move the print to iommu probing and adding functions
> 
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

LGTM, followed through since [1].
Acked-by: Pranjal Shrivastava <praan@google.com>

Thanks,
Praan

[1]
 https://lore.kernel.org/all/c30af43b93f04125bf9befe631922653@baidu.com/

  reply	other threads:[~2025-01-07  4:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07  3:35 [PATCH][v2] iommu: move the adding group info to proper place Li RongQing
2025-01-07  4:00 ` Pranjal Shrivastava [this message]
2025-01-07 12:22 ` Vasant Hegde
2025-01-07 12:30   ` 答复: [外部邮件] " Li,Rongqing
2025-01-07 13:46     ` Vasant Hegde
2025-02-11 10:14 ` 答复: " Li,Rongqing
2025-02-11 17:51 ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z3ym8Z73RcT_f8OZ@google.com \
    --to=praan@google.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=lirongqing@baidu.com \
    --cc=robin.murphy@arm.com \
    --cc=vasant.hegde@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox