Linux IOMMU Development
 help / color / mirror / Atom feed
From: "Li,Rongqing" <lirongqing@baidu.com>
To: Vasant Hegde <vasant.hegde@amd.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"will@kernel.org" <will@kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: 答复: [外部邮件] Re: [PATCH][v2] iommu: move the adding group info to proper place
Date: Tue, 7 Jan 2025 12:30:09 +0000	[thread overview]
Message-ID: <a78452d7e99e49e7af2b6e3a3c312bda@baidu.com> (raw)
In-Reply-To: <cafe5714-aeaa-4774-bdad-124e4e036ae7@amd.com>

> > -	if (IS_ERR(gdev))
> > -		return PTR_ERR(gdev);
> > +	if (IS_ERR(gdev)) {
> > +		ret = PTR_ERR(gdev);
> > +		dev_err(dev, "Failed to add to iommu group %d: %d\n", group->id,
> ret);
> > +		return ret;
> 
> Why not just return PTR_ERR(gdev)?
> 

Since dev_err will print PTR_ERR(gdev), so I define a local variable to conversion once


Thanks

-Li

> -Vasant


  reply	other threads:[~2025-01-07 12:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-07  3:35 [PATCH][v2] iommu: move the adding group info to proper place Li RongQing
2025-01-07  4:00 ` Pranjal Shrivastava
2025-01-07 12:22 ` Vasant Hegde
2025-01-07 12:30   ` Li,Rongqing [this message]
2025-01-07 13:46     ` 答复: [外部邮件] " Vasant Hegde
2025-02-11 10:14 ` 答复: " Li,Rongqing
2025-02-11 17:51 ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a78452d7e99e49e7af2b6e3a3c312bda@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=robin.murphy@arm.com \
    --cc=vasant.hegde@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox