* [PATCH] iommu/amd: Fix workqueue name
@ 2024-05-29 11:39 Vasant Hegde
2024-05-29 14:51 ` Borislav Petkov
2024-06-04 11:59 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Vasant Hegde @ 2024-05-29 11:39 UTC (permalink / raw)
To: iommu, joro; +Cc: suravee.suthikulpanit, Vasant Hegde, Borislav Petkov
Workqueue name length is crossing WQ_NAME_LEN limit. Fix it by changing
name format. New format : "iopf_queue/amdvi-<iommu-devid>"
kernel warning:
[ 11.146912] workqueue: name exceeds WQ_NAME_LEN. Truncating to: iopf_queue/amdiommu-0xc002-iopf
Reported-by: Borislav Petkov <bp@alien8.de>
Fixes: 61928bab9d26 ("iommu/amd: Define per-IOMMU iopf_queue")
Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
---
drivers/iommu/amd/ppr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/amd/ppr.c b/drivers/iommu/amd/ppr.c
index b3b690410f2a..7c67d69f0b8c 100644
--- a/drivers/iommu/amd/ppr.c
+++ b/drivers/iommu/amd/ppr.c
@@ -222,8 +222,7 @@ int amd_iommu_iopf_init(struct amd_iommu *iommu)
if (iommu->iopf_queue)
return ret;
- snprintf(iommu->iopfq_name, sizeof(iommu->iopfq_name),
- "amdiommu-%#x-iopfq",
+ snprintf(iommu->iopfq_name, sizeof(iommu->iopfq_name), "amdvi-%#x",
PCI_SEG_DEVID_TO_SBDF(iommu->pci_seg->id, iommu->devid));
iommu->iopf_queue = iopf_queue_alloc(iommu->iopfq_name);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/amd: Fix workqueue name
2024-05-29 11:39 [PATCH] iommu/amd: Fix workqueue name Vasant Hegde
@ 2024-05-29 14:51 ` Borislav Petkov
2024-06-04 11:59 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2024-05-29 14:51 UTC (permalink / raw)
To: Vasant Hegde; +Cc: iommu, joro, suravee.suthikulpanit
On Wed, May 29, 2024 at 11:39:00AM +0000, Vasant Hegde wrote:
> Workqueue name length is crossing WQ_NAME_LEN limit. Fix it by changing
> name format. New format : "iopf_queue/amdvi-<iommu-devid>"
>
> kernel warning:
> [ 11.146912] workqueue: name exceeds WQ_NAME_LEN. Truncating to: iopf_queue/amdiommu-0xc002-iopf
>
> Reported-by: Borislav Petkov <bp@alien8.de>
> Fixes: 61928bab9d26 ("iommu/amd: Define per-IOMMU iopf_queue")
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/iommu/amd/ppr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/amd/ppr.c b/drivers/iommu/amd/ppr.c
> index b3b690410f2a..7c67d69f0b8c 100644
> --- a/drivers/iommu/amd/ppr.c
> +++ b/drivers/iommu/amd/ppr.c
> @@ -222,8 +222,7 @@ int amd_iommu_iopf_init(struct amd_iommu *iommu)
> if (iommu->iopf_queue)
> return ret;
>
> - snprintf(iommu->iopfq_name, sizeof(iommu->iopfq_name),
> - "amdiommu-%#x-iopfq",
> + snprintf(iommu->iopfq_name, sizeof(iommu->iopfq_name), "amdvi-%#x",
> PCI_SEG_DEVID_TO_SBDF(iommu->pci_seg->id, iommu->devid));
>
> iommu->iopf_queue = iopf_queue_alloc(iommu->iopfq_name);
> --
Looks like it should fit, thx.
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/amd: Fix workqueue name
2024-05-29 11:39 [PATCH] iommu/amd: Fix workqueue name Vasant Hegde
2024-05-29 14:51 ` Borislav Petkov
@ 2024-06-04 11:59 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2024-06-04 11:59 UTC (permalink / raw)
To: Vasant Hegde; +Cc: iommu, suravee.suthikulpanit, Borislav Petkov
On Wed, May 29, 2024 at 11:39:00AM +0000, Vasant Hegde wrote:
> Workqueue name length is crossing WQ_NAME_LEN limit. Fix it by changing
> name format. New format : "iopf_queue/amdvi-<iommu-devid>"
>
> kernel warning:
> [ 11.146912] workqueue: name exceeds WQ_NAME_LEN. Truncating to: iopf_queue/amdiommu-0xc002-iopf
>
> Reported-by: Borislav Petkov <bp@alien8.de>
> Fixes: 61928bab9d26 ("iommu/amd: Define per-IOMMU iopf_queue")
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/iommu/amd/ppr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-04 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-29 11:39 [PATCH] iommu/amd: Fix workqueue name Vasant Hegde
2024-05-29 14:51 ` Borislav Petkov
2024-06-04 11:59 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox