Re: [RFC PATCH v2 05/10] iommu/arm-smmu-v3: Implement pm_runtime & system sleep ops

[Pranjal Shrivastava <praan@google.com>]

On Sun, May 04, 2025 at 01:29:36PM -0700, Daniel Mentz wrote:
> On Fri, Apr 18, 2025 at 4:35 PM Pranjal Shrivastava <praan@google.com> wrote:
> > +static int arm_smmu_rpm_get_if_active(struct arm_smmu_device *smmu)
> > +{
> > +       if (pm_runtime_enabled(smmu->dev))
> > +               return pm_runtime_get_if_in_use(smmu->dev);
> 
> You named this function arm_smmu_rpm_get_if_active but then call into
> pm_runtime_get_if_in_use (There's also a pm_runtime_get_if_active).
> Shouldn't this function be called arm_smmu_rpm_get_if_in_use?
> 

Ack, I'll rename the function to arm_smmu_rpm_get_if_in_use to be more
clear.

> > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> > @@ -506,6 +506,8 @@ static inline unsigned int arm_smmu_cdtab_l2_idx(unsigned int ssid)
> >  #define MSI_IOVA_BASE                  0x8000000
> >  #define MSI_IOVA_LENGTH                        0x100000
> >
> > +#define RPM_AUTOSUSPEND_DELAY_MS       15
> 
> Consider moving this to  "iommu/arm-smmu-v3: Enable pm_runtime and
> setup devlinks" where it's actually used for the first time.

Ack.

Thanks
Praan