* Re: [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output [not found] ` <CAHk-=wgB2YMM6kw8W0wq=7efxsRERL14OHMOLU=Nd1OaR+sXvw@mail.gmail.com> @ 2020-03-10 18:25 ` Christoph Hellwig [not found] ` <20200311152453.GB23704@lst.de> 0 siblings, 1 reply; 5+ messages in thread From: Christoph Hellwig @ 2020-03-10 18:25 UTC (permalink / raw) To: Linus Torvalds; +Cc: Greg Kroah-Hartman, iommu, aros, linux-kernel FYI, Linus' latest rant shows up in bugzilla, but never made it to me, just as the other replies from Artem and Hans. This just shows how broken bugzilla is as a reporting tool. Please be a little more calm, I've always taken reported regressions series and as a first priority, but it really does not help if information is hidden away. Adding Artem to the Cc list and drop bugzilla to make this work a bit better. Artem, can you test the patch below? This fixes the broken dma_mask handling in platform_device_register_full that could override a perfectly valid mask with 0. If this doesn't work, can you throw in a dump_stack() into the working kernel build to see where platform_device_register_full and setup_pdev_dma_masks get called for your system? diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 7fa654f1288b..03035661eb6b 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -662,19 +662,6 @@ struct platform_device *platform_device_register_full( pdev->dev.of_node_reused = pdevinfo->of_node_reused; if (pdevinfo->dma_mask) { - /* - * This memory isn't freed when the device is put, - * I don't have a nice idea for that though. Conceptually - * dma_mask in struct device should not be a pointer. - * See http://thread.gmane.org/gmane.linux.kernel.pci/9081 - */ - pdev->dev.dma_mask = - kmalloc(sizeof(*pdev->dev.dma_mask), GFP_KERNEL); - if (!pdev->dev.dma_mask) - goto err; - - kmemleak_ignore(pdev->dev.dma_mask); - *pdev->dev.dma_mask = pdevinfo->dma_mask; pdev->dev.coherent_dma_mask = pdevinfo->dma_mask; } _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <20200311152453.GB23704@lst.de>]
[parent not found: <e70dd793-e8b8-ab0c-6027-6c22b5a99bfc@gmx.com>]
[parent not found: <20200311154328.GA24044@lst.de>]
[parent not found: <20200311154718.GB24044@lst.de>]
[parent not found: <962693d9-b595-c44d-1390-e044f29e91d3@gmx.com>]
[parent not found: <CAHk-=wj0E9vCO_VTiK6xuXAW13ZeeLsW=G3v+yNsCaUm1+H61A@mail.gmail.com>]
[parent not found: <CAHk-=whFu_p-eiyJfiEevV=a+irzW=9LMWjMaaFSaaasXout9w@mail.gmail.com>]
* Re: [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output [not found] ` <CAHk-=whFu_p-eiyJfiEevV=a+irzW=9LMWjMaaFSaaasXout9w@mail.gmail.com> @ 2020-03-11 16:48 ` Linus Torvalds 2020-03-11 17:05 ` Artem S. Tashkinov 0 siblings, 1 reply; 5+ messages in thread From: Linus Torvalds @ 2020-03-11 16:48 UTC (permalink / raw) To: Artem S. Tashkinov Cc: Greg Kroah-Hartman, iommu, Christoph Hellwig, Linux Kernel Mailing List On Wed, Mar 11, 2020 at 9:24 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > So it will have a different commit ID, updated message, and be a mix > of my patch and Christoph's. I ended up pushing it out before starting on the pull requests, so it's out there now. Artem, it would be good to have confirmation that my (modified) tip of tree now works for you. I don't actually doubt it does, but a final confirmation would be appreciated. Linus _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output 2020-03-11 16:48 ` Linus Torvalds @ 2020-03-11 17:05 ` Artem S. Tashkinov 0 siblings, 0 replies; 5+ messages in thread From: Artem S. Tashkinov @ 2020-03-11 17:05 UTC (permalink / raw) To: Linus Torvalds Cc: Greg Kroah-Hartman, iommu, Christoph Hellwig, Linux Kernel Mailing List On 3/11/20 4:48 PM, Linus Torvalds wrote: > On Wed, Mar 11, 2020 at 9:24 AM Linus Torvalds > <torvalds@linux-foundation.org> wrote: >> >> So it will have a different commit ID, updated message, and be a mix >> of my patch and Christoph's. > > I ended up pushing it out before starting on the pull requests, so > it's out there now. > > Artem, it would be good to have confirmation that my (modified) tip of > tree now works for you. I don't actually doubt it does, but a final > confirmation would be appreciated. > Should I test kernel 5.6-rc5 with this patch applied or wait for you to commit it? _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output [not found] ` <CAHk-=wj0E9vCO_VTiK6xuXAW13ZeeLsW=G3v+yNsCaUm1+H61A@mail.gmail.com> [not found] ` <CAHk-=whFu_p-eiyJfiEevV=a+irzW=9LMWjMaaFSaaasXout9w@mail.gmail.com> @ 2020-03-11 17:21 ` Artem S. Tashkinov 2020-03-11 17:27 ` Linus Torvalds 1 sibling, 1 reply; 5+ messages in thread From: Artem S. Tashkinov @ 2020-03-11 17:21 UTC (permalink / raw) To: Linus Torvalds Cc: Greg Kroah-Hartman, iommu, Christoph Hellwig, Linux Kernel Mailing List On 3/11/20 4:21 PM, Linus Torvalds wrote: > On Wed, Mar 11, 2020 at 9:02 AM Artem S. Tashkinov <aros@gmx.com> wrote: >> >> With this patch the system works (I haven't created an initrd, so it >> doesn't completely boot and panics on not being able to mount root fs >> but that's expected). > > Perfect. > > I ended up applying my earlier cleanup patch with just the added > removal of the kfree(), which was the actual trigger of the bug. > > It's commit e423fb6929d4 ("driver code: clarify and fix platform > device DMA mask allocation") in my tree. I've not pushed it out yet (I > have a few pending pull requests), but it should be out shortly. I've been able to compile and run e3a36eb6dfaeea8175c05d5915dcf0b939be6dab successfully. I won't claim this patch doesn't break something for other people :-) Best regards, Artem _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output 2020-03-11 17:21 ` Artem S. Tashkinov @ 2020-03-11 17:27 ` Linus Torvalds 0 siblings, 0 replies; 5+ messages in thread From: Linus Torvalds @ 2020-03-11 17:27 UTC (permalink / raw) To: Artem S. Tashkinov Cc: Greg Kroah-Hartman, iommu, Christoph Hellwig, Linux Kernel Mailing List On Wed, Mar 11, 2020 at 10:21 AM Artem S. Tashkinov <aros@gmx.com> wrote: > > I've been able to compile and run > e3a36eb6dfaeea8175c05d5915dcf0b939be6dab successfully. I won't claim > this patch doesn't break something for other people :-) Thanks, that's all I was looking for. If it breaks something for somebody else, I have a solid plan for that too: I'll just sit in a corner and cry. Linus _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-11 17:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-206175-5873@https.bugzilla.kernel.org/>
[not found] ` <bug-206175-5873-S6PaNNClEr@https.bugzilla.kernel.org/>
[not found] ` <CAHk-=wi4GS05j67V0D_cRXRQ=_Jh-NT0OuNpF-JFsDFj7jZK9A@mail.gmail.com>
[not found] ` <20200310162342.GA4483@lst.de>
[not found] ` <CAHk-=wgB2YMM6kw8W0wq=7efxsRERL14OHMOLU=Nd1OaR+sXvw@mail.gmail.com>
2020-03-10 18:25 ` [Bug 206175] Fedora >= 5.4 kernels instantly freeze on boot without producing any display output Christoph Hellwig
[not found] ` <20200311152453.GB23704@lst.de>
[not found] ` <e70dd793-e8b8-ab0c-6027-6c22b5a99bfc@gmx.com>
[not found] ` <20200311154328.GA24044@lst.de>
[not found] ` <20200311154718.GB24044@lst.de>
[not found] ` <962693d9-b595-c44d-1390-e044f29e91d3@gmx.com>
[not found] ` <CAHk-=wj0E9vCO_VTiK6xuXAW13ZeeLsW=G3v+yNsCaUm1+H61A@mail.gmail.com>
[not found] ` <CAHk-=whFu_p-eiyJfiEevV=a+irzW=9LMWjMaaFSaaasXout9w@mail.gmail.com>
2020-03-11 16:48 ` Linus Torvalds
2020-03-11 17:05 ` Artem S. Tashkinov
2020-03-11 17:21 ` Artem S. Tashkinov
2020-03-11 17:27 ` Linus Torvalds
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox