* [PATCH] kconfig: do not define AUTOCONF_INCLUDED
@ 2010-12-05 6:31 Arnaud Lacombe
2010-12-15 6:23 ` Arnaud Lacombe
2010-12-15 12:43 ` Michal Marek
0 siblings, 2 replies; 3+ messages in thread
From: Arnaud Lacombe @ 2010-12-05 6:31 UTC (permalink / raw)
To: linux-kbuild; +Cc: Arnaud Lacombe
AUTOCONF_INCLUDED is not checked is not used within the tree and its parent
header, `autoconf.h', is safe to be re-included.
Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
---
scripts/kconfig/confdata.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 9df8011..f349bdc 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -833,8 +833,7 @@ int conf_write_autoconf(void)
" * Automatically generated C config: don't edit\n"
" * %s\n"
" * %s"
- " */\n"
- "#define AUTOCONF_INCLUDED\n",
+ " */\n",
rootmenu.prompt->text, ctime(&now));
for_all_symbols(i, sym) {
--
1.7.2.30.gc37d7.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] kconfig: do not define AUTOCONF_INCLUDED
2010-12-05 6:31 [PATCH] kconfig: do not define AUTOCONF_INCLUDED Arnaud Lacombe
@ 2010-12-15 6:23 ` Arnaud Lacombe
2010-12-15 12:43 ` Michal Marek
1 sibling, 0 replies; 3+ messages in thread
From: Arnaud Lacombe @ 2010-12-15 6:23 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek
Hi,
On Sun, Dec 5, 2010 at 1:31 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> AUTOCONF_INCLUDED is not checked is not used within the tree and its parent
> header, `autoconf.h', is safe to be re-included.
>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
> scripts/kconfig/confdata.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
ping ?
- Arnaud
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index 9df8011..f349bdc 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -833,8 +833,7 @@ int conf_write_autoconf(void)
> " * Automatically generated C config: don't edit\n"
> " * %s\n"
> " * %s"
> - " */\n"
> - "#define AUTOCONF_INCLUDED\n",
> + " */\n",
> rootmenu.prompt->text, ctime(&now));
>
> for_all_symbols(i, sym) {
> --
> 1.7.2.30.gc37d7.dirty
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kconfig: do not define AUTOCONF_INCLUDED
2010-12-05 6:31 [PATCH] kconfig: do not define AUTOCONF_INCLUDED Arnaud Lacombe
2010-12-15 6:23 ` Arnaud Lacombe
@ 2010-12-15 12:43 ` Michal Marek
1 sibling, 0 replies; 3+ messages in thread
From: Michal Marek @ 2010-12-15 12:43 UTC (permalink / raw)
To: Arnaud Lacombe; +Cc: linux-kbuild
On Sun, Dec 05, 2010 at 01:31:57AM -0500, Arnaud Lacombe wrote:
> AUTOCONF_INCLUDED is not checked is not used within the tree and its parent
> header, `autoconf.h', is safe to be re-included.
It could be used by external modules that try to be compatible with
pre-2.6.15 kernels, but the fix is trivial in such case (and I guess
most of them dropped the #include of autoconf.h after it moved from
linux/ to generated/ recently). So I applied this to
kbuild-2.6.git#kconfig, thanks.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-15 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-05 6:31 [PATCH] kconfig: do not define AUTOCONF_INCLUDED Arnaud Lacombe
2010-12-15 6:23 ` Arnaud Lacombe
2010-12-15 12:43 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox