From: Paul Bolle <pebolle@tiscali.nl>
To: Jonathan Toppins <jtoppins@cumulusnetworks.com>
Cc: Michal Marek <mmarek@suse.cz>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v1 kbuild for-next 1/2] makefiles: add config option to force all cc warnings to errors
Date: Wed, 18 Mar 2015 11:00:32 +0100 [thread overview]
Message-ID: <1426672832.2649.28.camel@tiscali.nl> (raw)
In-Reply-To: <5508B574.5030505@cumulusnetworks.com>
Jonathan Toppins schreef op di 17-03-2015 om 19:15 [-0400]:
> So default to "n"?
"n" is the default anyhow, so I think you never need it.
> Kconfig bases paragraph continuation on indention,
> correct?
Yes. It's a syntax I quite dislike, but we're stuck with it.
> Appreciate the review thanks.
My review ended up a bit blunt. But the patch defaults to y for every
configuration (because, I think, all of them source lib/Kconfig.debug)
for an option that would stop the build at the first warning it sees.
That's not really a considerate thing to do.
Paul Bolle
next prev parent reply other threads:[~2015-03-18 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 22:37 [PATCH v1 kbuild for-next 1/2] makefiles: add config option to force all cc warnings to errors Jonathan Toppins
2015-03-17 22:37 ` [PATCH v1 kbuild for-next 2/2] modpost: add Kconfig option to report warnings as errors Jonathan Toppins
2015-03-17 22:58 ` [PATCH v1 kbuild for-next 1/2] makefiles: add config option to force all cc warnings to errors Paul Bolle
2015-03-17 23:15 ` Jonathan Toppins
2015-03-18 10:00 ` Paul Bolle [this message]
2015-03-18 2:05 ` Jonathan Toppins
2015-03-18 10:16 ` Paul Bolle
2015-03-18 8:32 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426672832.2649.28.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=jtoppins@cumulusnetworks.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox