Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Jonathan Toppins <jtoppins@cumulusnetworks.com>
Cc: Michal Marek <mmarek@suse.cz>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v1 kbuild for-next 1/2] makefiles: add config option to force all cc warnings to errors
Date: Wed, 18 Mar 2015 11:16:30 +0100	[thread overview]
Message-ID: <1426673790.2649.41.camel@tiscali.nl> (raw)
In-Reply-To: <5508DD81.20006@cumulusnetworks.com>

Jonathan Toppins schreef op di 17-03-2015 om 22:05 [-0400]:
> Some slight background on these patches, they were born out of the team 
> here wanting to have a simple way of easily catching warnings during 
> driver development. This seemed like the least cumbersome way. I 
> understand if defaulting to yes is not advisable.
> 
> Will be happy to submit another patch defaulting to no and clean-up the 
> Dots in the paragraphs. From the comments provided so far this approach 
> would seem to address them, unless I am misunderstanding and in fact the 
> general idea of compiling with -Werror is not wanted.
> 
> Appreciate the discussion.

The builds are rather silent as is. Warnings already tend to stand out.
But to follow up on Michal's suggestion, every now and then I do
    grep ":[[:digit:]]\+:" $LOG

to catch all well behaved warnings. (I typed that from memory, so the
pattern might be wrong.) The occasional
    make $SOME_TARGET > /dev/null

does wonders too.

And, on a general note, the warnings spotting real issues get fixed
quite quickly. The warnings that actually do make it into releases are
almost always false positives. They might only get fixed if someone
finds a way to redo the code in such a way that the compiler has less
trouble analyzing it.

Thanks,


Paul Bolle


  reply	other threads:[~2015-03-18 10:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 22:37 [PATCH v1 kbuild for-next 1/2] makefiles: add config option to force all cc warnings to errors Jonathan Toppins
2015-03-17 22:37 ` [PATCH v1 kbuild for-next 2/2] modpost: add Kconfig option to report warnings as errors Jonathan Toppins
2015-03-17 22:58 ` [PATCH v1 kbuild for-next 1/2] makefiles: add config option to force all cc warnings to errors Paul Bolle
2015-03-17 23:15   ` Jonathan Toppins
2015-03-18 10:00     ` Paul Bolle
2015-03-18  2:05   ` Jonathan Toppins
2015-03-18 10:16     ` Paul Bolle [this message]
2015-03-18  8:32   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426673790.2649.41.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=jtoppins@cumulusnetworks.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox