public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
* (no subject)
@ 2023-04-21 14:35 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2023-04-21 14:35 UTC (permalink / raw)
  To: torvalds
  Cc: dhowells, Ekaterina Orlova, David Woodhouse, James Bottomley,
	Jarkko Sakkinen, keyrings, linux-kbuild, linux-kernel

Hi Linus,

Can you apply this, please?  It can probably wait for the merge window if you
don't want to apply it now as it only affects building the kernel.

Thanks,
David
---
From: Ekaterina Orlova <vorobushek.ok@gmail.com>

ASN.1: Fix check for strdup() success

It seems there is a misprint in the check of strdup() return code
that can lead to NULL pointer dereference.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 4520c6a49af8 ("X.509: Add simple ASN.1 grammar compiler")
Signed-off-by: Ekaterina Orlova <vorobushek.ok@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: David Woodhouse <dwmw2@infradead.org>
cc: James Bottomley <jejb@linux.ibm.com>
cc: Jarkko Sakkinen <jarkko@kernel.org>
cc: keyrings@vger.kernel.org
cc: linux-kbuild@vger.kernel.org
Link: https://lore.kernel.org/r/20230315172130.140-1-vorobushek.ok@gmail.com/
---
 scripts/asn1_compiler.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
index 7b6756a8c15d..4c3f645065a4 100644
--- a/scripts/asn1_compiler.c
+++ b/scripts/asn1_compiler.c
@@ -625,7 +625,7 @@ int main(int argc, char **argv)
 	p = strrchr(argv[1], '/');
 	p = p ? p + 1 : argv[1];
 	grammar_name = strdup(p);
-	if (!p) {
+	if (!grammar_name) {
 		perror(NULL);
 		exit(1);
 	}


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-21 14:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-21 14:35 David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox