* [Linux v5.19-rc2] rtla: Errors when running `make tools/clean`
@ 2022-06-14 22:23 Sedat Dilek
2022-06-27 6:23 ` Sedat Dilek
0 siblings, 1 reply; 4+ messages in thread
From: Sedat Dilek @ 2022-06-14 22:23 UTC (permalink / raw)
To: Daniel Bristot de Oliveira, Steven Rostedt
Cc: linux-trace-devel, Masahiro Yamada, linux-kbuild
[ CC linux-kbuild folks ]
Hi,
while digging into a perf issue I see this:
$ cd /path/to/linux.git
$ LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
...
DESCEND tracing
make[1]: Entering directory '/home/dileks/src/linux-kernel/git/tools/tracing'
DESCEND latency
make[2]: Entering directory
'/home/dileks/src/linux-kernel/git/tools/tracing/latency'
rm -f latency-collector
make[2]: Leaving directory
'/home/dileks/src/linux-kernel/git/tools/tracing/latency'
DESCEND rtla
make[2]: Entering directory
'/home/dileks/src/linux-kernel/git/tools/tracing/rtla'
make -C /home/dileks/src/linux-kernel/git/tools/tracing/rtla/../../../Documentation/tools/rtla/
clean
make[3]: Entering directory
'/home/dileks/src/linux-kernel/git/Documentation/tools/rtla'
rm -f rtla-osnoise-hist.1 rtla-osnoise-top.1 rtla-osnoise.1
rtla-timerlat-hist.1 rtla-timerlat-top.1 rtla-timerlat.1 rtla.1
make[3]: Leaving directory
'/home/dileks/src/linux-kernel/git/Documentation/tools/rtla'
/bin/sh: 1: test: rtla-make[2]:: unexpected operator
rm: cannot remove '/home/dileks/src/linux-kernel/git': Is a directory
make[2]: *** [Makefile:120: clean] Error 1
make[2]: Leaving directory
'/home/dileks/src/linux-kernel/git/tools/tracing/rtla'
make[1]: *** [Makefile:26: rtla_clean] Error 2
make[1]: Leaving directory '/home/dileks/src/linux-kernel/git/tools/tracing'
make: *** [Makefile:170: tracing_clean] Error 2
make: Leaving directory '/home/dileks/src/linux-kernel/git/tools'
Please check yourself.
Regards,
-Sedat-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux v5.19-rc2] rtla: Errors when running `make tools/clean`
2022-06-14 22:23 [Linux v5.19-rc2] rtla: Errors when running `make tools/clean` Sedat Dilek
@ 2022-06-27 6:23 ` Sedat Dilek
2022-06-30 9:57 ` Daniel Bristot de Oliveira
0 siblings, 1 reply; 4+ messages in thread
From: Sedat Dilek @ 2022-06-27 6:23 UTC (permalink / raw)
To: Daniel Bristot de Oliveira, Steven Rostedt
Cc: linux-trace-devel, Masahiro Yamada, linux-kbuild
On Wed, Jun 15, 2022 at 12:23 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> [ CC linux-kbuild folks ]
>
> Hi,
>
> while digging into a perf issue I see this:
>
> $ cd /path/to/linux.git
>
> $ LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
> ...
> DESCEND tracing
> make[1]: Entering directory '/home/dileks/src/linux-kernel/git/tools/tracing'
> DESCEND latency
> make[2]: Entering directory
> '/home/dileks/src/linux-kernel/git/tools/tracing/latency'
> rm -f latency-collector
> make[2]: Leaving directory
> '/home/dileks/src/linux-kernel/git/tools/tracing/latency'
> DESCEND rtla
> make[2]: Entering directory
> '/home/dileks/src/linux-kernel/git/tools/tracing/rtla'
> make -C /home/dileks/src/linux-kernel/git/tools/tracing/rtla/../../../Documentation/tools/rtla/
> clean
> make[3]: Entering directory
> '/home/dileks/src/linux-kernel/git/Documentation/tools/rtla'
> rm -f rtla-osnoise-hist.1 rtla-osnoise-top.1 rtla-osnoise.1
> rtla-timerlat-hist.1 rtla-timerlat-top.1 rtla-timerlat.1 rtla.1
> make[3]: Leaving directory
> '/home/dileks/src/linux-kernel/git/Documentation/tools/rtla'
> /bin/sh: 1: test: rtla-make[2]:: unexpected operator
> rm: cannot remove '/home/dileks/src/linux-kernel/git': Is a directory
> make[2]: *** [Makefile:120: clean] Error 1
> make[2]: Leaving directory
> '/home/dileks/src/linux-kernel/git/tools/tracing/rtla'
> make[1]: *** [Makefile:26: rtla_clean] Error 2
> make[1]: Leaving directory '/home/dileks/src/linux-kernel/git/tools/tracing'
> make: *** [Makefile:170: tracing_clean] Error 2
> make: Leaving directory '/home/dileks/src/linux-kernel/git/tools'
>
> Please check yourself.
>
> Regards,
> -Sedat-
Friendly pting!
The issue still remains with Linux v5.19-rc4:
$ head -5 Makefile
# SPDX-License-Identifier: GPL-2.0
VERSION = 5
PATCHLEVEL = 19
SUBLEVEL = 0
EXTRAVERSION = -rc4
$ LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
[ ... ]
DESCEND rtla
make[2]: Entering directory '/home/dileks/src/linux/git/tools/tracing/rtla'
make -C /home/dileks/src/linux/git/tools/tracing/rtla/../../../Documentation/tools/rtla/
clean
make[3]: Entering directory
'/home/dileks/src/linux/git/Documentation/tools/rtla'
rm -f rtla-osnoise-hist.1 rtla-osnoise-top.1 rtla-osnoise.1
rtla-timerlat-hist.1 rtla-timerlat-top.1 rtla-timerlat.1 rtla.1
make[3]: Leaving directory '/home/dileks/src/linux/git/Documentation/tools/rtla'
/bin/sh: 1: test: rtla-make[2]:: unexpected operator
rm: cannot remove '/home/dileks/src/linux/git': Is a directory
make[2]: *** [Makefile:120: clean] Error 1
make[2]: Leaving directory '/home/dileks/src/linux/git/tools/tracing/rtla'
make[1]: *** [Makefile:26: rtla_clean] Error 2
make[1]: Leaving directory '/home/dileks/src/linux/git/tools/tracing'
make: *** [Makefile:170: tracing_clean] Error 2
make: Leaving directory '/home/dileks/src/linux/git/tools'
-sed@-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux v5.19-rc2] rtla: Errors when running `make tools/clean`
2022-06-27 6:23 ` Sedat Dilek
@ 2022-06-30 9:57 ` Daniel Bristot de Oliveira
2022-07-01 8:08 ` Sedat Dilek
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Bristot de Oliveira @ 2022-06-30 9:57 UTC (permalink / raw)
To: sedat.dilek
Cc: linux-trace-devel, Masahiro Yamada, linux-kbuild, Steven Rostedt
Hi Sedat,
On 6/27/22 08:23, Sedat Dilek wrote:
> On Wed, Jun 15, 2022 at 12:23 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> [ CC linux-kbuild folks ]
>>
>> Hi,
>>
>> while digging into a perf issue I see this:
>>
>> $ cd /path/to/linux.git
>>
>> $ LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
>> ...
Do you mind trying this?
diff --git a/tools/tracing/rtla/Makefile b/tools/tracing/rtla/Makefile
index 3822f4ea5f49..1bea2d16d4c1 100644
--- a/tools/tracing/rtla/Makefile
+++ b/tools/tracing/rtla/Makefile
@@ -1,6 +1,6 @@
NAME := rtla
# Follow the kernel version
-VERSION := $(shell cat VERSION 2> /dev/null || make -sC ../../.. kernelversion)
+VERSION := $(shell cat VERSION 2> /dev/null || make -sC ../../.. kernelversion | grep -v make)
# From libtracefs:
# Makefiles suck: This macro sets a default value of $(2) for the
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Linux v5.19-rc2] rtla: Errors when running `make tools/clean`
2022-06-30 9:57 ` Daniel Bristot de Oliveira
@ 2022-07-01 8:08 ` Sedat Dilek
0 siblings, 0 replies; 4+ messages in thread
From: Sedat Dilek @ 2022-07-01 8:08 UTC (permalink / raw)
To: Daniel Bristot de Oliveira
Cc: linux-trace-devel, Masahiro Yamada, linux-kbuild, Steven Rostedt
On Thu, Jun 30, 2022 at 11:57 AM Daniel Bristot de Oliveira
<bristot@kernel.org> wrote:
>
> Hi Sedat,
>
> On 6/27/22 08:23, Sedat Dilek wrote:
> > On Wed, Jun 15, 2022 at 12:23 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >> [ CC linux-kbuild folks ]
> >>
> >> Hi,
> >>
> >> while digging into a perf issue I see this:
> >>
> >> $ cd /path/to/linux.git
> >>
> >> $ LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
> >> ...
>
> Do you mind trying this?
>
> diff --git a/tools/tracing/rtla/Makefile b/tools/tracing/rtla/Makefile
> index 3822f4ea5f49..1bea2d16d4c1 100644
> --- a/tools/tracing/rtla/Makefile
> +++ b/tools/tracing/rtla/Makefile
> @@ -1,6 +1,6 @@
> NAME := rtla
> # Follow the kernel version
> -VERSION := $(shell cat VERSION 2> /dev/null || make -sC ../../.. kernelversion)
> +VERSION := $(shell cat VERSION 2> /dev/null || make -sC ../../.. kernelversion | grep -v make)
>
> # From libtracefs:
> # Makefiles suck: This macro sets a default value of $(2) for the
Thanks for the diff Daniel.
Indeed, it fixes the build-error for me.
$ cd /path/to/linux.git
$ git status -s
M tools/tracing/rtla/Makefile
$ LANG=C LC_ALL=C make -C tools/ clean 2>&1 | tee ../make-log_tools-clean.txt
[ ... ]
DESCEND rtla
make[2]: Entering directory '/home/dileks/src/linux/git/tools/tracing/rtla'
make -C /home/dileks/src/linux/git/tools/tracing/rtla/../../../Documentation/tools/rtla/
clean
make[3]: Entering directory
'/home/dileks/src/linux/git/Documentation/tools/rtla'
rm -f rtla-osnoise-hist.1 rtla-osnoise-top.1 rtla-osnoise.1
rtla-timerlat-hist.1 rtla-timerlat-top.1 rtla-timerlat.1 rtla.1
make[3]: Leaving directory '/home/dileks/src/linux/git/Documentation/tools/rtla'
make[2]: Leaving directory '/home/dileks/src/linux/git/tools/tracing/rtla'
make[1]: Leaving directory '/home/dileks/src/linux/git/tools/tracing'
Please feel free to add my...
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
...when you have prepared a real fix.
-sed@-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-01 8:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-14 22:23 [Linux v5.19-rc2] rtla: Errors when running `make tools/clean` Sedat Dilek
2022-06-27 6:23 ` Sedat Dilek
2022-06-30 9:57 ` Daniel Bristot de Oliveira
2022-07-01 8:08 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox