From: Sam Ravnborg <sam@ravnborg.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
jdike@addtoit.com, linux-kbuild@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Patch] UML build: fix missing posix_types.h
Date: Thu, 31 Jul 2008 22:16:02 +0200 [thread overview]
Message-ID: <20080731201602.GC25158@uranus.ravnborg.org> (raw)
In-Reply-To: <20080731121028.GA23636@hack.voiplan.pt>
On Thu, Jul 31, 2008 at 01:10:28PM +0100, WANG Cong wrote:
>
> When building UML with 'O=foo' specified, I got:
>
> CC kernel/bounds.s
> In file included from
> /home/wangcong/Projects/linux-2.6/include/linux/types.h:11,
> from
> /home/wangcong/Projects/linux-2.6/include/linux/page-flags.h:8,
> from
> /home/wangcong/Projects/linux-2.6/kernel/bounds.c:9:
> /home/wangcong/Projects/linux-2.6/include/linux/posix_types.h:47:29:
> error: asm/posix_types.h: No such file or directory
> In file included from
> /home/wangcong/Projects/linux-2.6/include/linux/page-flags.h:8,
> from
> /home/wangcong/Projects/linux-2.6/kernel/bounds.c:9:
> /home/wangcong/Projects/linux-2.6/include/linux/types.h:12:23: error:
> asm/types.h: No such file or directory
> In file included from
> /home/wangcong/Projects/linux-2.6/include/linux/page-flags.h:8,
>
> Below patch fixed it, note, it is only tested for x86 and um.
>
> Signed-off-by: WANG Cong <wangcong@zeuux.org>
> Cc: sam@ravnborg.org
> Cc: jdike@addtoit.com
>
> ---
> diff --git a/Makefile b/Makefile
> index aa527a4..39130d1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -930,7 +930,8 @@ ifneq ($(KBUILD_SRC),)
> /bin/false; \
> fi;
> $(Q)if [ ! -d include2 ]; then mkdir -p include2; fi;
> - $(Q)if [ -e $(srctree)/include/asm-$(SRCARCH)/system.h ]; then \
> + $(Q)if [ -e $(srctree)/include/asm-$(SRCARCH)/system.h -o \
> + -e $(objtree)/include/asm-$(SRCARCH)/system.h ] ; then \
> ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm; \
> fi
> endif
I have a similar patch locally. I just check for errno.h so I
do not have to do the extra check in objtree.
Will push tonight.
Sam
prev parent reply other threads:[~2008-07-31 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 12:10 [Patch] UML build: fix missing posix_types.h WANG Cong
2008-07-31 20:16 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731201602.GC25158@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox