public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 04/13] scripts/package: don't break if %{_smp_mflags} isn't set
@ 2008-10-29 21:20 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2008-10-29 21:20 UTC (permalink / raw)
  To: sam; +Cc: linux-kbuild, akpm, jk

From: Jeremy Kerr <jk@ozlabs.org>

Currently, if we do a 'make rpm-pkg' without the _smp_mflags rpm macro
defined, the build fails with:

  [snip]
  Executing(%build): /bin/bash -e /var/tmp/rpm-tmp.67959
  + umask 022
  + cd /home/jk/devel/kernel-snapshot/rpm/BUILD
  + cd kernel-2.6.26
  + make clean
  + make '%{_smp_mflags}'
  make[3]: *** No rule to make target `%{_smp_mflags}'.  Stop.
  error: Bad exit status from /var/tmp/rpm-tmp.67959 (%build)

This change uses the 'null if not set' reference to the _smp_mflags
macro instead.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 scripts/package/mkspec |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN scripts/package/mkspec~scripts-package-dont-break-if-%_smp_mflags-isnt-set scripts/package/mkspec
--- a/scripts/package/mkspec~scripts-package-dont-break-if-%_smp_mflags-isnt-set
+++ a/scripts/package/mkspec
@@ -57,7 +57,7 @@ fi
 echo "%build"
 
 if ! $PREBUILT; then
-echo "make clean && make %{_smp_mflags}"
+echo "make clean && make %{?_smp_mflags}"
 echo ""
 fi
 
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-10-29 21:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 21:20 [patch 04/13] scripts/package: don't break if %{_smp_mflags} isn't set akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox