From: Sam Ravnborg <sam@ravnborg.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kbuild@vger.kernel.org, Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: [PATCH] headerdep: fix option processing for -I
Date: Sun, 5 Apr 2009 21:50:06 +0200 [thread overview]
Message-ID: <20090405195006.GD24374@uranus.ravnborg.org> (raw)
In-Reply-To: <20090329182617.GA25154@pengutronix.de>
On Sun, Mar 29, 2009 at 08:26:17PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> sorry for replying to my own mail, but I found a further enhancement.
>
> On Sun, Mar 29, 2009 at 03:01:47PM +0200, Uwe Kleine-König wrote:
> > -I takes an argument. Without this change only a 1 is added to
> > @opt_include which is not helpful.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Vegard Nossum <vegard.nossum@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> >
> > ---
> > scripts/headerdep.pl | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> > index 97399da..536408e 100755
> > --- a/scripts/headerdep.pl
> > +++ b/scripts/headerdep.pl
> > @@ -19,7 +19,7 @@ my $opt_graph;
> > version => \&version,
> >
> > all => \$opt_all,
> > - I => \@opt_include,
> > + "I:s" => \@opt_include,
> This should better be "I=s". The difference is that with : the argument
> is optional, with = it is not.
Applied with this fix and Vegards ack.
Sam
prev parent reply other threads:[~2009-04-05 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 13:01 [PATCH] headerdep: fix option processing for -I Uwe Kleine-König
2009-03-29 13:33 ` Vegard Nossum
2009-03-29 18:26 ` Uwe Kleine-König
2009-04-05 19:50 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090405195006.GD24374@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox