* [PATCH] headerdep: fix option processing for -I
@ 2009-03-29 13:01 Uwe Kleine-König
2009-03-29 13:33 ` Vegard Nossum
2009-03-29 18:26 ` Uwe Kleine-König
0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2009-03-29 13:01 UTC (permalink / raw)
To: linux-kbuild; +Cc: Vegard Nossum, Sam Ravnborg
-I takes an argument. Without this change only a 1 is added to
@opt_include which is not helpful.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
| 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--git a/scripts/headerdep.pl b/scripts/headerdep.pl
index 97399da..536408e 100755
--- a/scripts/headerdep.pl
+++ b/scripts/headerdep.pl
@@ -19,7 +19,7 @@ my $opt_graph;
version => \&version,
all => \$opt_all,
- I => \@opt_include,
+ "I:s" => \@opt_include,
graph => \$opt_graph,
);
--
tg: (5d80f8e..) t/misc/fix_include_opt_for_headerdep (depends on: linus/master)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] headerdep: fix option processing for -I
2009-03-29 13:01 [PATCH] headerdep: fix option processing for -I Uwe Kleine-König
@ 2009-03-29 13:33 ` Vegard Nossum
2009-03-29 18:26 ` Uwe Kleine-König
1 sibling, 0 replies; 4+ messages in thread
From: Vegard Nossum @ 2009-03-29 13:33 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kbuild, Sam Ravnborg
2009/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> -I takes an argument. Without this change only a 1 is added to
> @opt_include which is not helpful.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Vegard Nossum <vegard.nossum@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
>
> ---
> scripts/headerdep.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> index 97399da..536408e 100755
> --- a/scripts/headerdep.pl
> +++ b/scripts/headerdep.pl
> @@ -19,7 +19,7 @@ my $opt_graph;
> version => \&version,
>
> all => \$opt_all,
> - I => \@opt_include,
> + "I:s" => \@opt_include,
> graph => \$opt_graph,
> );
Thanks!
Acked-by: Vegard Nossum <vegard.nossum@gmail.com>
Vegard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] headerdep: fix option processing for -I
2009-03-29 13:01 [PATCH] headerdep: fix option processing for -I Uwe Kleine-König
2009-03-29 13:33 ` Vegard Nossum
@ 2009-03-29 18:26 ` Uwe Kleine-König
2009-04-05 19:50 ` Sam Ravnborg
1 sibling, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2009-03-29 18:26 UTC (permalink / raw)
To: linux-kbuild; +Cc: Vegard Nossum, Sam Ravnborg
Hello,
sorry for replying to my own mail, but I found a further enhancement.
On Sun, Mar 29, 2009 at 03:01:47PM +0200, Uwe Kleine-König wrote:
> -I takes an argument. Without this change only a 1 is added to
> @opt_include which is not helpful.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Vegard Nossum <vegard.nossum@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
>
> ---
> scripts/headerdep.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> index 97399da..536408e 100755
> --- a/scripts/headerdep.pl
> +++ b/scripts/headerdep.pl
> @@ -19,7 +19,7 @@ my $opt_graph;
> version => \&version,
>
> all => \$opt_all,
> - I => \@opt_include,
> + "I:s" => \@opt_include,
This should better be "I=s". The difference is that with : the argument
is optional, with = it is not.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] headerdep: fix option processing for -I
2009-03-29 18:26 ` Uwe Kleine-König
@ 2009-04-05 19:50 ` Sam Ravnborg
0 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2009-04-05 19:50 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kbuild, Vegard Nossum
On Sun, Mar 29, 2009 at 08:26:17PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> sorry for replying to my own mail, but I found a further enhancement.
>
> On Sun, Mar 29, 2009 at 03:01:47PM +0200, Uwe Kleine-König wrote:
> > -I takes an argument. Without this change only a 1 is added to
> > @opt_include which is not helpful.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Vegard Nossum <vegard.nossum@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> >
> > ---
> > scripts/headerdep.pl | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/scripts/headerdep.pl b/scripts/headerdep.pl
> > index 97399da..536408e 100755
> > --- a/scripts/headerdep.pl
> > +++ b/scripts/headerdep.pl
> > @@ -19,7 +19,7 @@ my $opt_graph;
> > version => \&version,
> >
> > all => \$opt_all,
> > - I => \@opt_include,
> > + "I:s" => \@opt_include,
> This should better be "I=s". The difference is that with : the argument
> is optional, with = it is not.
Applied with this fix and Vegards ack.
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-05 19:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-29 13:01 [PATCH] headerdep: fix option processing for -I Uwe Kleine-König
2009-03-29 13:33 ` Vegard Nossum
2009-03-29 18:26 ` Uwe Kleine-König
2009-04-05 19:50 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox