* IRQ subsystem menu
@ 2012-10-21 7:40 Paul Thompson
2012-10-29 14:03 ` Michal Marek
0 siblings, 1 reply; 5+ messages in thread
From: Paul Thompson @ 2012-10-21 7:40 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
Hi;
In menuconfig, General setup -> IRQ subsystem, there are two
possible menu-items. One depends partly on IRQ_DOMAIN, and the other
on MAY_HAVE_SPARSE_IRQ.
On the x86-64 arch, neither of these seems to be set, so the
menu entry is blank if entered (displaying an odd ^@ if you try to
navigate up or down. And sometimes some screen garbage on the sides.)
Previously (in the 3.2 kernel at least) this menu used to be
populated by the "Support sparse IRQ numbering" menu-item, which
at that time depended on HAVE_SPARSE_IRQ, and was forced to YES.
I do not know if the current behaviour is intended, but it
is ugly and confusing to be confronted with a blank menu page.
Ideally, the "IRQ subsystem" menu would not even show up
if it would contain no menu-items, but I do not know enough to
formulate that constraint.
A simple alternative is a comment section to reasure babes in
the wood of kernel configuration that something is not amiss. I include
a sample patch.
Paul
set.mailinglist@gmail.com
[-- Attachment #2: irq-kconfig.patch --]
[-- Type: text/plain, Size: 375 bytes --]
--- linux-3.7-rc2/kernel/irq/Kconfig.orig 2012-10-20 15:11:32.000000000 -0400
+++ linux-3.7-rc2/kernel/irq/Kconfig 2012-10-21 03:14:56.272952813 -0400
@@ -4,6 +4,9 @@ config HAVE_GENERIC_HARDIRQS
if HAVE_GENERIC_HARDIRQS
menu "IRQ subsystem"
+
+comment "Some configurations may have no available options here"
+
#
# Interrupt subsystem related configuration options
#
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: IRQ subsystem menu
2012-10-21 7:40 IRQ subsystem menu Paul Thompson
@ 2012-10-29 14:03 ` Michal Marek
2012-11-29 20:32 ` Grant Likely
0 siblings, 1 reply; 5+ messages in thread
From: Michal Marek @ 2012-10-29 14:03 UTC (permalink / raw)
To: Paul Thompson; +Cc: linux-kbuild, linux-kernel, Thomas Gleixner
(Adding lkml and Thomas as IRQ subsystem maintainer to CC)
On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> Hi;
>
> In menuconfig, General setup -> IRQ subsystem, there are two
> possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> on MAY_HAVE_SPARSE_IRQ.
>
> On the x86-64 arch, neither of these seems to be set, so the
> menu entry is blank if entered (displaying an odd ^@ if you try to
> navigate up or down. And sometimes some screen garbage on the sides.)
>
> Previously (in the 3.2 kernel at least) this menu used to be
> populated by the "Support sparse IRQ numbering" menu-item, which
> at that time depended on HAVE_SPARSE_IRQ, and was forced to YES.
>
> I do not know if the current behaviour is intended, but it
> is ugly and confusing to be confronted with a blank menu page.
>
> Ideally, the "IRQ subsystem" menu would not even show up
> if it would contain no menu-items, but I do not know enough to
> formulate that constraint.
>
> A simple alternative is a comment section to reasure babes in
> the wood of kernel configuration that something is not amiss. I include
> a sample patch.
>
> Paul
> set.mailinglist@gmail.com
> --- linux-3.7-rc2/kernel/irq/Kconfig.orig 2012-10-20 15:11:32.000000000 -0400
> +++ linux-3.7-rc2/kernel/irq/Kconfig 2012-10-21 03:14:56.272952813 -0400
> @@ -4,6 +4,9 @@ config HAVE_GENERIC_HARDIRQS
>
> if HAVE_GENERIC_HARDIRQS
> menu "IRQ subsystem"
> +
> +comment "Some configurations may have no available options here"
> +
> #
> # Interrupt subsystem related configuration options
> #
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: IRQ subsystem menu
2012-10-29 14:03 ` Michal Marek
@ 2012-11-29 20:32 ` Grant Likely
2012-12-06 2:16 ` Paul Thompson
0 siblings, 1 reply; 5+ messages in thread
From: Grant Likely @ 2012-11-29 20:32 UTC (permalink / raw)
To: Michal Marek, Paul Thompson; +Cc: linux-kbuild, linux-kernel, Thomas Gleixner
On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@suse.cz> wrote:
> (Adding lkml and Thomas as IRQ subsystem maintainer to CC)
>
> On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> > Hi;
> >
> > In menuconfig, General setup -> IRQ subsystem, there are two
> > possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> > on MAY_HAVE_SPARSE_IRQ.
> >
> > On the x86-64 arch, neither of these seems to be set, so the
> > menu entry is blank if entered (displaying an odd ^@ if you try to
> > navigate up or down. And sometimes some screen garbage on the sides.)
> >
> > Previously (in the 3.2 kernel at least) this menu used to be
> > populated by the "Support sparse IRQ numbering" menu-item, which
> > at that time depended on HAVE_SPARSE_IRQ, and was forced to YES.
> >
> > I do not know if the current behaviour is intended, but it
> > is ugly and confusing to be confronted with a blank menu page.
> >
> > Ideally, the "IRQ subsystem" menu would not even show up
> > if it would contain no menu-items, but I do not know enough to
> > formulate that constraint.
First, move the 'menu "IRQ subsystem"' line does to right before the
IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you
can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right
below the menu item.
You'll also need to move the IRQ_FORCED_THREADING line out from inside
the menu block.
Try it out and let me know how it goes.
g.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: IRQ subsystem menu
2012-11-29 20:32 ` Grant Likely
@ 2012-12-06 2:16 ` Paul Thompson
2012-12-10 23:18 ` Grant Likely
0 siblings, 1 reply; 5+ messages in thread
From: Paul Thompson @ 2012-12-06 2:16 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kbuild, linux-kernel, Thomas Gleixner
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
Grant Likely <grant.likely@secretlab.ca>, on Thu 2012.11.29 said:
> On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@suse.cz> wrote:
> > (Adding lkml and Thomas as IRQ subsystem maintainer to CC)
> >
> > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> > > Hi;
> > >
> > > In menuconfig, General setup -> IRQ subsystem, there are two
> > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> > > on MAY_HAVE_SPARSE_IRQ.
> > >
[...]
> > >
> > > Ideally, the "IRQ subsystem" menu would not even show up
> > > if it would contain no menu-items, but I do not know enough to
> > > formulate that constraint.
>
> First, move the 'menu "IRQ subsystem"' line does to right before the
> IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you
> can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right
> below the menu item.
>
> You'll also need to move the IRQ_FORCED_THREADING line out from inside
> the menu block.
>
> Try it out and let me know how it goes.
>
> g.
Hi;
The logic makes sense to me, and makes the menus appearance
dependent on if either option setting can exist. So, on my system,
the IRQ subsystem menu does not appear.
Paul
See if this attached patch looks right:
[-- Attachment #2: irq-menu.patch --]
[-- Type: text/plain, Size: 937 bytes --]
--- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500
+++ linux-3.7-rc8/kernel/irq/Kconfig 2012-12-05 21:00:18.454788693 -0500
@@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS
bool
if HAVE_GENERIC_HARDIRQS
-menu "IRQ subsystem"
#
# Interrupt subsystem related configuration options
#
@@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP
config IRQ_DOMAIN
bool
+# Support forced irq threading
+config IRQ_FORCED_THREADING
+ bool
+
+menu "IRQ subsystem"
+ depends on ( IRQ_DOMAIN && DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ
+
config IRQ_DOMAIN_DEBUG
bool "Expose hardware/virtual IRQ mapping via debugfs"
depends on IRQ_DOMAIN && DEBUG_FS
@@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG
If you don't know what this means you don't need it.
-# Support forced irq threading
-config IRQ_FORCED_THREADING
- bool
-
config SPARSE_IRQ
bool "Support sparse irq numbering" if MAY_HAVE_SPARSE_IRQ
---help---
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: IRQ subsystem menu
2012-12-06 2:16 ` Paul Thompson
@ 2012-12-10 23:18 ` Grant Likely
0 siblings, 0 replies; 5+ messages in thread
From: Grant Likely @ 2012-12-10 23:18 UTC (permalink / raw)
To: Paul Thompson; +Cc: linux-kbuild, linux-kernel, Thomas Gleixner
On Wed, 5 Dec 2012 21:16:20 -0500, Paul Thompson <set48035@gmail.com> wrote:
> Grant Likely <grant.likely@secretlab.ca>, on Thu 2012.11.29 said:
> > On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@suse.cz> wrote:
> > > (Adding lkml and Thomas as IRQ subsystem maintainer to CC)
> > >
> > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> > > > Hi;
> > > >
> > > > In menuconfig, General setup -> IRQ subsystem, there are two
> > > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> > > > on MAY_HAVE_SPARSE_IRQ.
> > > >
> [...]
> > > >
> > > > Ideally, the "IRQ subsystem" menu would not even show up
> > > > if it would contain no menu-items, but I do not know enough to
> > > > formulate that constraint.
> >
> > First, move the 'menu "IRQ subsystem"' line does to right before the
> > IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you
> > can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right
> > below the menu item.
> >
> > You'll also need to move the IRQ_FORCED_THREADING line out from inside
> > the menu block.
> >
> > Try it out and let me know how it goes.
> >
> > g.
>
> Hi;
>
> The logic makes sense to me, and makes the menus appearance
> dependent on if either option setting can exist. So, on my system,
> the IRQ subsystem menu does not appear.
>
> Paul
Looks right to me. Please repost with a proper commit log and
"Signed-off-by" line and I'll apply this patch.
(See Documentation/SubmittingPatches)
g.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-10 23:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-21 7:40 IRQ subsystem menu Paul Thompson
2012-10-29 14:03 ` Michal Marek
2012-11-29 20:32 ` Grant Likely
2012-12-06 2:16 ` Paul Thompson
2012-12-10 23:18 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox