public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Jarod Wilson <jarod@redhat.com>, Michal Marek <mmarek@suse.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [regression ?] kbuild: fix building bzImage with CONFIG_TRIM_UNUSED_KSYMS enabled
Date: Fri, 9 Dec 2016 13:58:57 +0900	[thread overview]
Message-ID: <20161209045857.GD4661@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.20.1612082235510.1657@knanqh.ubzr>

On (12/08/16 22:40), Nicolas Pitre wrote:
> > > after 53924022d8a ("kbuild: fix building bzImage withCONFIG_TRIM_UNUSED_KSYMS
> > > enabled") all of my build scripts build the kernel without the modules.
> > 
> > [..]
> > > +# For the kernel to actually contain only the needed exported symbols,
> > > +# we have to build modules as well to determine what those symbols are.
> > > +# (this can be evaluated only once include/config/auto.conf has been included)
> > 					^^^^^
> > 
> > ah, the config. so the patch is wrong.
> 
> Furthermore, the export statement exports the variable not its value. 
> Even if the value is changed afterwards, referencing the exported 
> variable will see the new value.

yeah, need to investigate more. for some, unknown, reason
modules_install gives me empty lib/modules.

the build script (archlinux) builds it in 2 steps: build() and package().
basically:

build:
make -j4 > build_log 2>&1

package:
make -j4 INSTALL_MOD_PATH="${pkgdir}" modules_install >> build_log 2>&1



makepkg
ls -la
pkg/kernel-4.9.0-rc8-dbg-00085-ga37102d-dirty/lib/modules/4.9.0-rc8-dbg-00085-ga37102d-dirty/kernel/
drwxr-xr-x 2 ss ss 4096 Dec  9 13:51 .
drwxr-xr-x 3 ss ss 4096 Dec  9 13:51 ..


git revert 865563924022d8
makepkg
ls -la pkg/kernel-4.9.0-rc8-dbg-00086-g7ea3980-dirty/lib/modules/4.9.0-rc8-dbg-00086-g7ea3980-dirty/kernel/
drwxr-xr-x 10 ss ss 4096 Dec  9 13:55 .
drwxr-xr-x  3 ss ss 4096 Dec  9 13:55 ..
drwxr-xr-x  3 ss ss 4096 Dec  9 13:55 arch
drwxr-xr-x  2 ss ss 4096 Dec  9 13:55 crypto
drwxr-xr-x 14 ss ss 4096 Dec  9 13:55 drivers
drwxr-xr-x  4 ss ss 4096 Dec  9 13:55 fs
drwxr-xr-x  4 ss ss 4096 Dec  9 13:55 lib
drwxr-xr-x  2 ss ss 4096 Dec  9 13:55 mm
drwxr-xr-x  3 ss ss 4096 Dec  9 13:55 net
drwxr-xr-x  5 ss ss 4096 Dec  9 13:55 sound


revert-the-revert

git revert 7ea39801035a23
[master 7b90890] Revert "Revert "kbuild: fix building bzImage with CONFIG_TRIM_UNUSED_KSYMS enabled""


makepkg
ls -la
pkg/kernel-4.9.0-rc8-dbg-00087-g7b90890-dirty/lib/modules/4.9.0-rc8-dbg-00087-g7b90890-dirty/kernel/
drwxr-xr-x 2 ss ss 4096 Dec  9 13:56 .
drwxr-xr-x 3 ss ss 4096 Dec  9 13:56 ..


not sure I see why...

	-ss

  reply	other threads:[~2016-12-09  4:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09  2:43 [regression ?] kbuild: fix building bzImage with CONFIG_TRIM_UNUSED_KSYMS enabled Sergey Senozhatsky
2016-12-09  2:56 ` Sergey Senozhatsky
2016-12-09  3:40   ` Nicolas Pitre
2016-12-09  4:58     ` Sergey Senozhatsky [this message]
2016-12-09 18:07       ` Nicolas Pitre
2016-12-10  7:23         ` Sergey Senozhatsky
2016-12-10 21:04           ` Nicolas Pitre
2016-12-11  2:19             ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161209045857.GD4661@jagdpanzerIV.localdomain \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=jarod@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=nicolas.pitre@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox