From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Jarod Wilson <jarod@redhat.com>, Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [regression ?] kbuild: fix building bzImage with CONFIG_TRIM_UNUSED_KSYMS enabled
Date: Sat, 10 Dec 2016 16:23:05 +0900 [thread overview]
Message-ID: <20161210072305.GA6394@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.20.1612091302540.1657@knanqh.ubzr>
On (12/09/16 13:07), Nicolas Pitre wrote:
[..]
> > build:
> > make -j4 > build_log 2>&1
> >
> > package:
> > make -j4 INSTALL_MOD_PATH="${pkgdir}" modules_install >> build_log 2>&1
>
> Weird.
it is. sorry for long reply, it took me some time to track it down.
turned out, the script also does `prepare' and `kernelrelease'. so
the sequence of commands in my build script is
make prepare
make kernelrelease
# functon build
make -j4
# finction package
make -j4 INSTALL_MOD_PATH=XXXX modules_install
now. the problem here is that, apparently, and I didn't know that,
"make prepare" and "make kernelrelease" are executed twice.
- first time when I build the kernel
make prepare
make kernelrelease
make -j4
- second time when I install the modules
make prepare
make kernelrelease
make -j4 INSTALL_MOD_PATH=XXXX modules_install
so this will not install modules:
make prepare; make kernelrelease; make -j4; make prepare; make kernelrelease; make -j4 INSTALL_MOD_PATH=/tmp/MODULES modules_install
and this will:
make prepare; make kernelrelease; make -j4; make kernelrelease; make -j4 INSTALL_MOD_PATH=/tmp/MODULES modules_install
> You must have CONFIG_TRIM_UNUSED_KSYMS=y in your .config, right?
yes.
> What if you set it to n instead without reverting 865563924022d8. Do you
> still have the same issue?
!CONFIG_TRIM_UNUSED_KSYMS or !865563924022d8 builds just fine with extra
`make prepare'.
no `extra make prepare' builds ok regardless the state of Makefile/config
files.
I guess you don't need my .config any more.
-ss
next prev parent reply other threads:[~2016-12-10 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 2:43 [regression ?] kbuild: fix building bzImage with CONFIG_TRIM_UNUSED_KSYMS enabled Sergey Senozhatsky
2016-12-09 2:56 ` Sergey Senozhatsky
2016-12-09 3:40 ` Nicolas Pitre
2016-12-09 4:58 ` Sergey Senozhatsky
2016-12-09 18:07 ` Nicolas Pitre
2016-12-10 7:23 ` Sergey Senozhatsky [this message]
2016-12-10 21:04 ` Nicolas Pitre
2016-12-11 2:19 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210072305.GA6394@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=jarod@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.pitre@linaro.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox