From: Steven Rostedt <rostedt@goodmis.org>
To: David Lin <dtwlin@google.com>
Cc: mmarek@suse.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, jbaron@akamai.com,
will.deacon@arm.com
Subject: Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support
Date: Mon, 2 Jan 2017 13:51:11 -0500 [thread overview]
Message-ID: <20170102135111.26d5f5bd@grimm.local.home> (raw)
In-Reply-To: <CAPzFB+Wwn+qMh8esnoJ+E4Zym1V7JQZoztz70bPH0HqZSNpGjg@mail.gmail.com>
On Sun, 1 Jan 2017 15:05:45 -0800
David Lin <dtwlin@google.com> wrote:
> +Cc: Steven Rostedt <rostedt@goodmis.org>
> +Cc: Will Deacon <will.deacon@arm.com>
>
> On Fri, Dec 9, 2016 at 4:46 PM, David Lin <dtwlin@google.com> wrote:
> > Some versions of ARM GCC compiler such as Android toolchain throws
> > in a '-fpic' flag by default. This causes the gcc-goto check script
> > to fail although some config would have '-fno-pic' flag in the
> > KBUILD_CFLAGS.
> >
> > This patch passes the KBUILD_CFLAGS to the check script so that the
> > script does not rely on the default config from different compilers.
> >
> > Signed-off-by: David Lin <dtwlin@google.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org.
-- Steve
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 694111b..f667daa 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -790,7 +790,7 @@ KBUILD_CFLAGS += $(call
> > cc-option,-Werror=incompatible-pointer-types) KBUILD_ARFLAGS :=
> > $(call ar-option,D)
> >
> > # check for 'asm goto'
> > -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh
> > $(CC)), y) +ifeq ($(shell $(CONFIG_SHELL)
> > $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
> > KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO KBUILD_AFLAGS +=
> > -DCC_HAVE_ASM_GOTO endif
> > --
> > 2.10.2
> >
prev parent reply other threads:[~2017-01-02 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 0:46 [PATCH] jump label: pass kbuild_cflags when checking for asm goto support David Lin
2017-01-01 23:05 ` David Lin
2017-01-02 18:51 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102135111.26d5f5bd@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=dtwlin@google.com \
--cc=jbaron@akamai.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox