* [PATCH] jump label: pass kbuild_cflags when checking for asm goto support
@ 2016-12-10 0:46 David Lin
2017-01-01 23:05 ` David Lin
0 siblings, 1 reply; 3+ messages in thread
From: David Lin @ 2016-12-10 0:46 UTC (permalink / raw)
To: mmarek, linux-kbuild, linux-kernel, jbaron; +Cc: David Lin
Some versions of ARM GCC compiler such as Android toolchain throws in a
'-fpic' flag by default. This causes the gcc-goto check script to fail
although some config would have '-fno-pic' flag in the KBUILD_CFLAGS.
This patch passes the KBUILD_CFLAGS to the check script so that the
script does not rely on the default config from different compilers.
Signed-off-by: David Lin <dtwlin@google.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 694111b..f667daa 100644
--- a/Makefile
+++ b/Makefile
@@ -790,7 +790,7 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)
KBUILD_ARFLAGS := $(call ar-option,D)
# check for 'asm goto'
-ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
+ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
endif
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support
2016-12-10 0:46 [PATCH] jump label: pass kbuild_cflags when checking for asm goto support David Lin
@ 2017-01-01 23:05 ` David Lin
2017-01-02 18:51 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: David Lin @ 2017-01-01 23:05 UTC (permalink / raw)
To: mmarek, linux-kbuild, linux-kernel, jbaron, rostedt, will.deacon
Cc: David Lin
+Cc: Steven Rostedt <rostedt@goodmis.org>
+Cc: Will Deacon <will.deacon@arm.com>
On Fri, Dec 9, 2016 at 4:46 PM, David Lin <dtwlin@google.com> wrote:
> Some versions of ARM GCC compiler such as Android toolchain throws in a
> '-fpic' flag by default. This causes the gcc-goto check script to fail
> although some config would have '-fno-pic' flag in the KBUILD_CFLAGS.
>
> This patch passes the KBUILD_CFLAGS to the check script so that the
> script does not rely on the default config from different compilers.
>
> Signed-off-by: David Lin <dtwlin@google.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 694111b..f667daa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -790,7 +790,7 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)
> KBUILD_ARFLAGS := $(call ar-option,D)
>
> # check for 'asm goto'
> -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
> +ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
> KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
> KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
> endif
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support
2017-01-01 23:05 ` David Lin
@ 2017-01-02 18:51 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2017-01-02 18:51 UTC (permalink / raw)
To: David Lin; +Cc: mmarek, linux-kbuild, linux-kernel, jbaron, will.deacon
On Sun, 1 Jan 2017 15:05:45 -0800
David Lin <dtwlin@google.com> wrote:
> +Cc: Steven Rostedt <rostedt@goodmis.org>
> +Cc: Will Deacon <will.deacon@arm.com>
>
> On Fri, Dec 9, 2016 at 4:46 PM, David Lin <dtwlin@google.com> wrote:
> > Some versions of ARM GCC compiler such as Android toolchain throws
> > in a '-fpic' flag by default. This causes the gcc-goto check script
> > to fail although some config would have '-fno-pic' flag in the
> > KBUILD_CFLAGS.
> >
> > This patch passes the KBUILD_CFLAGS to the check script so that the
> > script does not rely on the default config from different compilers.
> >
> > Signed-off-by: David Lin <dtwlin@google.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org.
-- Steve
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 694111b..f667daa 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -790,7 +790,7 @@ KBUILD_CFLAGS += $(call
> > cc-option,-Werror=incompatible-pointer-types) KBUILD_ARFLAGS :=
> > $(call ar-option,D)
> >
> > # check for 'asm goto'
> > -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh
> > $(CC)), y) +ifeq ($(shell $(CONFIG_SHELL)
> > $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
> > KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO KBUILD_AFLAGS +=
> > -DCC_HAVE_ASM_GOTO endif
> > --
> > 2.10.2
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-02 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-10 0:46 [PATCH] jump label: pass kbuild_cflags when checking for asm goto support David Lin
2017-01-01 23:05 ` David Lin
2017-01-02 18:51 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox