* [PATCH AUTOSEL 5.3 50/89] kbuild: fix build error of 'make nsdeps' in clean tree
[not found] <20191018220324.8165-1-sashal@kernel.org>
@ 2019-10-18 22:02 ` Sasha Levin
2019-10-19 0:14 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2019-10-18 22:02 UTC (permalink / raw)
To: linux-kernel, stable
Cc: Masahiro Yamada, Matthias Maennich, Jessica Yu, Sasha Levin,
linux-kbuild
From: Masahiro Yamada <yamada.masahiro@socionext.com>
[ Upstream commit d85103ac78a6d8573b21348b36f4cca2e1839a31 ]
Running 'make nsdeps' in a clean source tree fails as follows:
$ make -s clean; make -s defconfig; make nsdeps
[ snip ]
awk: fatal: cannot open file `init/modules.order' for reading (No such file or directory)
make: *** [Makefile;1307: modules.order] Error 2
make: *** Deleting file 'modules.order'
make: *** Waiting for unfinished jobs....
The cause of the error is 'make nsdeps' does not build modules at all.
Set KBUILD_MODULES to fix it.
Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index d7469f0926a67..62b9640d007a0 100644
--- a/Makefile
+++ b/Makefile
@@ -594,7 +594,7 @@ endif
# in addition to whatever we do anyway.
# Just "make" or "make all" shall build modules as well
-ifneq ($(filter all _all modules,$(MAKECMDGOALS)),)
+ifneq ($(filter all _all modules nsdeps,$(MAKECMDGOALS)),)
KBUILD_MODULES := 1
endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 5.3 50/89] kbuild: fix build error of 'make nsdeps' in clean tree
2019-10-18 22:02 ` [PATCH AUTOSEL 5.3 50/89] kbuild: fix build error of 'make nsdeps' in clean tree Sasha Levin
@ 2019-10-19 0:14 ` Masahiro Yamada
2019-10-29 9:09 ` Sasha Levin
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2019-10-19 0:14 UTC (permalink / raw)
To: Sasha Levin
Cc: Linux Kernel Mailing List, stable, Matthias Maennich, Jessica Yu,
Linux Kbuild mailing list
On Sat, Oct 19, 2019 at 7:04 AM Sasha Levin <sashal@kernel.org> wrote:
>
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> [ Upstream commit d85103ac78a6d8573b21348b36f4cca2e1839a31 ]
>
> Running 'make nsdeps' in a clean source tree fails as follows:
>
> $ make -s clean; make -s defconfig; make nsdeps
> [ snip ]
> awk: fatal: cannot open file `init/modules.order' for reading (No such file or directory)
> make: *** [Makefile;1307: modules.order] Error 2
> make: *** Deleting file 'modules.order'
> make: *** Waiting for unfinished jobs....
>
> The cause of the error is 'make nsdeps' does not build modules at all.
> Set KBUILD_MODULES to fix it.
>
> Reviewed-by: Matthias Maennich <maennich@google.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Jessica Yu <jeyu@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
nsdeps was introduced in v5.4
Please do not backport this commit.
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d7469f0926a67..62b9640d007a0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -594,7 +594,7 @@ endif
> # in addition to whatever we do anyway.
> # Just "make" or "make all" shall build modules as well
>
> -ifneq ($(filter all _all modules,$(MAKECMDGOALS)),)
> +ifneq ($(filter all _all modules nsdeps,$(MAKECMDGOALS)),)
> KBUILD_MODULES := 1
> endif
>
> --
> 2.20.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH AUTOSEL 5.3 50/89] kbuild: fix build error of 'make nsdeps' in clean tree
2019-10-19 0:14 ` Masahiro Yamada
@ 2019-10-29 9:09 ` Sasha Levin
0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2019-10-29 9:09 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kernel Mailing List, stable, Matthias Maennich, Jessica Yu,
Linux Kbuild mailing list
On Sat, Oct 19, 2019 at 09:14:13AM +0900, Masahiro Yamada wrote:
>On Sat, Oct 19, 2019 at 7:04 AM Sasha Levin <sashal@kernel.org> wrote:
>>
>> From: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>> [ Upstream commit d85103ac78a6d8573b21348b36f4cca2e1839a31 ]
>>
>> Running 'make nsdeps' in a clean source tree fails as follows:
>>
>> $ make -s clean; make -s defconfig; make nsdeps
>> [ snip ]
>> awk: fatal: cannot open file `init/modules.order' for reading (No such file or directory)
>> make: *** [Makefile;1307: modules.order] Error 2
>> make: *** Deleting file 'modules.order'
>> make: *** Waiting for unfinished jobs....
>>
>> The cause of the error is 'make nsdeps' does not build modules at all.
>> Set KBUILD_MODULES to fix it.
>>
>> Reviewed-by: Matthias Maennich <maennich@google.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Jessica Yu <jeyu@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>
>nsdeps was introduced in v5.4
>
>Please do not backport this commit.
I've dropped it everywhere, thank you.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191018220324.8165-1-sashal@kernel.org>
2019-10-18 22:02 ` [PATCH AUTOSEL 5.3 50/89] kbuild: fix build error of 'make nsdeps' in clean tree Sasha Levin
2019-10-19 0:14 ` Masahiro Yamada
2019-10-29 9:09 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox