* [PATCH 2/2] fix the SPDX syntax and bash interprester pointer
@ 2019-12-03 9:53 Bhaskar Chowdhury
2019-12-05 3:36 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Bhaskar Chowdhury @ 2019-12-03 9:53 UTC (permalink / raw)
To: yamada.masahiro, michal.lkml, rdunlap
Cc: linux-kbuild, linux-kernel, Bhaskar Chowdhury
SPDX syntax was complining by checkpatch fixed it,added space before it.
And add bash interpreter to find by the env .
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
scripts/kernel_modules_info.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh
index f005c47a3aa6..3a9b00988ed3 100755
--- a/scripts/kernel_modules_info.sh
+++ b/scripts/kernel_modules_info.sh
@@ -1,5 +1,5 @@
-#!/bin/bash -
-#SPDX-License-Identifier: GPL-2.0
+#!/usr/bin/env bash
+# SPDX-License-Identifier: GPL-2.0
#===============================================================================
#
# FILE: kernel_modules_info.sh
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] fix the SPDX syntax and bash interprester pointer
2019-12-03 9:53 [PATCH 2/2] fix the SPDX syntax and bash interprester pointer Bhaskar Chowdhury
@ 2019-12-05 3:36 ` Randy Dunlap
2019-12-05 5:14 ` Bhaskar Chowdhury
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2019-12-05 3:36 UTC (permalink / raw)
To: Bhaskar Chowdhury, yamada.masahiro, michal.lkml
Cc: linux-kbuild, linux-kernel
On 12/3/19 1:53 AM, Bhaskar Chowdhury wrote:
> SPDX syntax was complining by checkpatch fixed it,added space before it.
> And add bash interpreter to find by the env .
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> scripts/kernel_modules_info.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh
> index f005c47a3aa6..3a9b00988ed3 100755
> --- a/scripts/kernel_modules_info.sh
> +++ b/scripts/kernel_modules_info.sh
> @@ -1,5 +1,5 @@
> -#!/bin/bash -
> -#SPDX-License-Identifier: GPL-2.0
> +#!/usr/bin/env bash
> +# SPDX-License-Identifier: GPL-2.0
> #===============================================================================
> #
> # FILE: kernel_modules_info.sh
>
a. There is no good reason for patch 2/2. Just merge the 2 patches.
b. The big header comment in patch 1/2 is not needed and is unwanted.
Just put some or all of that in the patch description/comment message.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] fix the SPDX syntax and bash interprester pointer
2019-12-05 3:36 ` Randy Dunlap
@ 2019-12-05 5:14 ` Bhaskar Chowdhury
0 siblings, 0 replies; 3+ messages in thread
From: Bhaskar Chowdhury @ 2019-12-05 5:14 UTC (permalink / raw)
To: Randy Dunlap; +Cc: yamada.masahiro, michal.lkml, linux-kbuild, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On 19:36 Wed 04 Dec 2019, Randy Dunlap wrote:
>On 12/3/19 1:53 AM, Bhaskar Chowdhury wrote:
>> SPDX syntax was complining by checkpatch fixed it,added space before it.
>> And add bash interpreter to find by the env .
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> scripts/kernel_modules_info.sh | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh
>> index f005c47a3aa6..3a9b00988ed3 100755
>> --- a/scripts/kernel_modules_info.sh
>> +++ b/scripts/kernel_modules_info.sh
>> @@ -1,5 +1,5 @@
>> -#!/bin/bash -
>> -#SPDX-License-Identifier: GPL-2.0
>> +#!/usr/bin/env bash
>> +# SPDX-License-Identifier: GPL-2.0
>> #===============================================================================
>> #
>> # FILE: kernel_modules_info.sh
>>
>
>a. There is no good reason for patch 2/2. Just merge the 2 patches.
>
>b. The big header comment in patch 1/2 is not needed and is unwanted.
>Just put some or all of that in the patch description/comment message.
>
Sure, will do.
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-05 5:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-03 9:53 [PATCH 2/2] fix the SPDX syntax and bash interprester pointer Bhaskar Chowdhury
2019-12-05 3:36 ` Randy Dunlap
2019-12-05 5:14 ` Bhaskar Chowdhury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox