From: Sasha Levin <sashal@kernel.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: linux-kbuild@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH] kbuild: simplify access to the kernel's version
Date: Mon, 8 Feb 2021 13:17:14 -0500 [thread overview]
Message-ID: <20210208181714.GZ4035784@sasha-vm> (raw)
In-Reply-To: <CA+icZUW5=1sTpo5XinSrjD5_J6o0QmoR5RsPUcnQXxdhcZdv1A@mail.gmail.com>
On Mon, Feb 08, 2021 at 04:28:00AM +0100, Sedat Dilek wrote:
>[ Please CC me directly ]
>
>Hi Sasha,
>
>I like that patch from [1].
>
>What was the Linux-source base?
>
>Searching in Linux v5.11-rc7:
>
>$ git grep -E 'LINUX_VERSION_CODE >> (16|8)'
>drivers/net/ethernet/mellanox/mlx5/core/main.c:
>(u8)((LINUX_VERSION_CODE >> 16) & 0xff), (u8)((LINUX_VERSION_CODE >>
>8) & 0xff),
>drivers/scsi/gdth.c: osv.version = (u8)(LINUX_VERSION_CODE >> 16);
>drivers/scsi/gdth.c: osv.subversion = (u8)(LINUX_VERSION_CODE >> 8);
>drivers/usb/core/hcd.c:#define KERNEL_REL
>bin2bcd(((LINUX_VERSION_CODE >> 16) & 0x0ff))
>drivers/usb/core/hcd.c:#define KERNEL_VER
>bin2bcd(((LINUX_VERSION_CODE >> 8) & 0x0ff))
>drivers/usb/gadget/udc/aspeed-vhub/hub.c:#define KERNEL_REL
>bin2bcd(((LINUX_VERSION_CODE >> 16) & 0x0ff))
>drivers/usb/gadget/udc/aspeed-vhub/hub.c:#define KERNEL_VER
>bin2bcd(((LINUX_VERSION_CODE >> 8) & 0x0ff))
>include/linux/usb/composite.h: bcdDevice =
>bin2bcd((LINUX_VERSION_CODE >> 16 & 0xff)) << 8;
>include/linux/usb/composite.h: bcdDevice |=
>bin2bcd((LINUX_VERSION_CODE >> 8 & 0xff));
>kernel/sys.c: v = ((LINUX_VERSION_CODE >> 8) & 0xff) + 60;
>
>So, drivers/scsi/gdth.c file is missing in your list of file:
Right. It's on it's way out: 0653c358d2dc ("scsi: Drop gdth driver").
In theory I should have fixed it too, but given that this patch is
cosmetic I just wanted to avoid unnecessary conflicts for SFR... If it
doesn't end up being removed we can always fix it up there.
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-02-08 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 3:28 [PATCH] kbuild: simplify access to the kernel's version Sedat Dilek
2021-02-08 18:17 ` Sasha Levin [this message]
2021-02-08 19:26 ` Sedat Dilek
-- strict thread matches above, loose matches on Subject: below --
2021-02-07 16:13 Sasha Levin
2021-02-08 7:40 ` Greg KH
2021-02-08 17:50 ` Christoph Hellwig
2021-02-08 18:20 ` Sasha Levin
2021-02-11 20:18 ` Masahiro Yamada
2021-02-12 3:40 ` Masahiro Yamada
2021-02-12 3:41 ` Masahiro Yamada
2021-02-12 16:19 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208181714.GZ4035784@sasha-vm \
--to=sashal@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox