public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>
Subject: Re: [PATCH 1/2] kbuild: builddeb: Remove unused $dirs
Date: Tue, 21 Nov 2023 14:37:40 +0100	[thread overview]
Message-ID: <20231121133740.GA126856@pevik> (raw)
In-Reply-To: <20231121115855.111358-1-pvorel@suse.cz>

Hi,

I could have added some description, e.g. "shell variable $dirs is not used any
more since 1fc9095846cc, therefore remove it".

Please let me know if I should resent it as v2.

Kind regards,
Petr

> Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  scripts/package/buildtar | 2 --
>  1 file changed, 2 deletions(-)

> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 65b4ea502962..8ac075dd0e9c 100755
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -23,7 +23,6 @@ tmpdir=$1

>  rm -rf -- "${tmpdir}"
>  mkdir -p -- "${tmpdir}/boot"
> -dirs=boot



> @@ -42,7 +41,6 @@ fi

>  if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
>  	make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
> -	dirs="$dirs lib"
>  fi

  parent reply	other threads:[~2023-11-21 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 11:58 [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
2023-11-21 11:58 ` [PATCH 2/2] kbuild: buildtar: always make modules_install Petr Vorel
2023-11-24 13:54   ` Masahiro Yamada
2023-11-21 13:37 ` Petr Vorel [this message]
2023-11-24  9:33   ` [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Masahiro Yamada
2023-11-24 16:28     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121133740.GA126856@pevik \
    --to=pvorel@suse.cz \
    --cc=josh@joshtriplett.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox