* [PATCH 1/2] kbuild: builddeb: Remove unused $dirs
@ 2023-11-21 11:58 Petr Vorel
2023-11-21 11:58 ` [PATCH 2/2] kbuild: buildtar: always make modules_install Petr Vorel
2023-11-21 13:37 ` [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
0 siblings, 2 replies; 6+ messages in thread
From: Petr Vorel @ 2023-11-21 11:58 UTC (permalink / raw)
To: linux-kbuild
Cc: Petr Vorel, Masahiro Yamada, Josh Triplett, Nathan Chancellor,
Nick Desaulniers, Nicolas Schier
Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
scripts/package/buildtar | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/package/buildtar b/scripts/package/buildtar
index 65b4ea502962..8ac075dd0e9c 100755
--- a/scripts/package/buildtar
+++ b/scripts/package/buildtar
@@ -23,7 +23,6 @@ tmpdir=$1
#
rm -rf -- "${tmpdir}"
mkdir -p -- "${tmpdir}/boot"
-dirs=boot
#
@@ -42,7 +41,6 @@ fi
#
if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
- dirs="$dirs lib"
fi
--
2.42.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] kbuild: buildtar: always make modules_install
2023-11-21 11:58 [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
@ 2023-11-21 11:58 ` Petr Vorel
2023-11-24 13:54 ` Masahiro Yamada
2023-11-21 13:37 ` [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
1 sibling, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2023-11-21 11:58 UTC (permalink / raw)
To: linux-kbuild
Cc: Petr Vorel, Masahiro Yamada, Josh Triplett, Nathan Chancellor,
Nick Desaulniers, Nicolas Schier, Petr Vorel
From: Petr Vorel <petr.vorel@gmail.com>
It is done for the same reasons as 4243afdb9326 does it for builddeb:
always runs make modules to install modules.builtin* files, which are
needed for e.g. initramfs-tools or LTP testing tool.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
scripts/package/buildtar | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/scripts/package/buildtar b/scripts/package/buildtar
index 8ac075dd0e9c..72c91a1b832f 100755
--- a/scripts/package/buildtar
+++ b/scripts/package/buildtar
@@ -37,11 +37,9 @@ fi
#
-# Try to install modules
+# Install modules
#
-if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
- make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
-fi
+make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
#
--
2.42.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] kbuild: builddeb: Remove unused $dirs
2023-11-21 11:58 [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
2023-11-21 11:58 ` [PATCH 2/2] kbuild: buildtar: always make modules_install Petr Vorel
@ 2023-11-21 13:37 ` Petr Vorel
2023-11-24 9:33 ` Masahiro Yamada
1 sibling, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2023-11-21 13:37 UTC (permalink / raw)
To: linux-kbuild
Cc: Masahiro Yamada, Josh Triplett, Nathan Chancellor,
Nick Desaulniers, Nicolas Schier
Hi,
I could have added some description, e.g. "shell variable $dirs is not used any
more since 1fc9095846cc, therefore remove it".
Please let me know if I should resent it as v2.
Kind regards,
Petr
> Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> scripts/package/buildtar | 2 --
> 1 file changed, 2 deletions(-)
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 65b4ea502962..8ac075dd0e9c 100755
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -23,7 +23,6 @@ tmpdir=$1
> rm -rf -- "${tmpdir}"
> mkdir -p -- "${tmpdir}/boot"
> -dirs=boot
> @@ -42,7 +41,6 @@ fi
> if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
> make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
> - dirs="$dirs lib"
> fi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] kbuild: builddeb: Remove unused $dirs
2023-11-21 13:37 ` [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
@ 2023-11-24 9:33 ` Masahiro Yamada
2023-11-24 16:28 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2023-11-24 9:33 UTC (permalink / raw)
To: Petr Vorel
Cc: linux-kbuild, Josh Triplett, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier
On Tue, Nov 21, 2023 at 10:37 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi,
>
> I could have added some description, e.g. "shell variable $dirs is not used any
> more since 1fc9095846cc, therefore remove it".
>
> Please let me know if I should resent it as v2.
>
> Kind regards,
> Petr
>
> > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package")
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
I filled the commit log and fixed the commit subject
"kbuild: builddeb:" to "kbuild: buildtar:".
Author: Petr Vorel <pvorel@suse.cz>
Date: Tue Nov 21 12:58:54 2023 +0100
kbuild: buildtar: Remove unused $dirs
The shell variable $dirs is not used any more since 1fc9095846cc
("kbuild: tar-pkg: use tar rules in scripts/Makefile.package"),
therefore remove it".
Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in
scripts/Makefile.package")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks.
> > ---
> > scripts/package/buildtar | 2 --
> > 1 file changed, 2 deletions(-)
>
> > diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> > index 65b4ea502962..8ac075dd0e9c 100755
> > --- a/scripts/package/buildtar
> > +++ b/scripts/package/buildtar
> > @@ -23,7 +23,6 @@ tmpdir=$1
>
> > rm -rf -- "${tmpdir}"
> > mkdir -p -- "${tmpdir}/boot"
> > -dirs=boot
>
>
>
> > @@ -42,7 +41,6 @@ fi
>
> > if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
> > make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
> > - dirs="$dirs lib"
> > fi
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] kbuild: buildtar: always make modules_install
2023-11-21 11:58 ` [PATCH 2/2] kbuild: buildtar: always make modules_install Petr Vorel
@ 2023-11-24 13:54 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2023-11-24 13:54 UTC (permalink / raw)
To: Petr Vorel
Cc: linux-kbuild, Petr Vorel, Josh Triplett, Nathan Chancellor,
Nick Desaulniers, Nicolas Schier
On Tue, Nov 21, 2023 at 8:59 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> From: Petr Vorel <petr.vorel@gmail.com>
>
> It is done for the same reasons as 4243afdb9326 does it for builddeb:
> always runs make modules to install modules.builtin* files, which are
> needed for e.g. initramfs-tools or LTP testing tool.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
Applied to linux-kbuild.
> scripts/package/buildtar | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 8ac075dd0e9c..72c91a1b832f 100755
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -37,11 +37,9 @@ fi
>
>
> #
> -# Try to install modules
> +# Install modules
> #
> -if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
> - make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
> -fi
> +make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
>
>
> #
> --
> 2.42.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] kbuild: builddeb: Remove unused $dirs
2023-11-24 9:33 ` Masahiro Yamada
@ 2023-11-24 16:28 ` Petr Vorel
0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2023-11-24 16:28 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, Josh Triplett, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier
Hi Masahiro,
> On Tue, Nov 21, 2023 at 10:37 PM Petr Vorel <pvorel@suse.cz> wrote:
> > Hi,
> > I could have added some description, e.g. "shell variable $dirs is not used any
> > more since 1fc9095846cc, therefore remove it".
> > Please let me know if I should resent it as v2.
> > Kind regards,
> > Petr
> > > Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package")
> > > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> I filled the commit log and fixed the commit subject
> "kbuild: builddeb:" to "kbuild: buildtar:".
Thanks for fixing this!
Kind regards,
Petr
> Author: Petr Vorel <pvorel@suse.cz>
> Date: Tue Nov 21 12:58:54 2023 +0100
> kbuild: buildtar: Remove unused $dirs
> The shell variable $dirs is not used any more since 1fc9095846cc
> ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package"),
> therefore remove it".
> Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in
> scripts/Makefile.package")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Thanks.
> > > ---
> > > scripts/package/buildtar | 2 --
> > > 1 file changed, 2 deletions(-)
> > > diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> > > index 65b4ea502962..8ac075dd0e9c 100755
> > > --- a/scripts/package/buildtar
> > > +++ b/scripts/package/buildtar
> > > @@ -23,7 +23,6 @@ tmpdir=$1
> > > rm -rf -- "${tmpdir}"
> > > mkdir -p -- "${tmpdir}/boot"
> > > -dirs=boot
> > > @@ -42,7 +41,6 @@ fi
> > > if grep -q '^CONFIG_MODULES=y' include/config/auto.conf; then
> > > make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_install
> > > - dirs="$dirs lib"
> > > fi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-24 16:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21 11:58 [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
2023-11-21 11:58 ` [PATCH 2/2] kbuild: buildtar: always make modules_install Petr Vorel
2023-11-24 13:54 ` Masahiro Yamada
2023-11-21 13:37 ` [PATCH 1/2] kbuild: builddeb: Remove unused $dirs Petr Vorel
2023-11-24 9:33 ` Masahiro Yamada
2023-11-24 16:28 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox