From: Dmitry Safonov <0x7f454c46@gmail.com>
To: mailingradian@gmail.com
Cc: kent.overstreet@linux.dev, linux-kbuild@vger.kernel.org,
masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu,
Dmitry Safonov <0x7f454c46@gmail.com>
Subject: [PATCH -next] kbuild: explicitly run mksysmap as sed script from link-vmlinux.sh
Date: Fri, 7 Jun 2024 00:14:21 +0100 [thread overview]
Message-ID: <20240606231422.57599-1-0x7f454c46@gmail.com> (raw)
In-Reply-To: <20240605034903.373617-2-mailingradian@gmail.com>
On Wed, Jun 5, 2024 at 12:49 PM Richard Acayan <mailingradian@gmail.com> wrote:
>
> In commit b18b047002b7 ("kbuild: change scripts/mksysmap into sed
> script"), the mksysmap script was transformed into a sed script,
> made directly executable with "#!/bin/sed -f". Apparently, the path to
> sed is different on NixOS, fixed by using the env command.
>
> To accommodate the number of arguments above the normal maximum for
> hashbangs, the -S flag of env was used (as in
> "#!/usr/bin/env -S sed -f"). However, env -S is a GNU extension.
> Explicitly use sed instead of relying on the executable shebang to keep
> compatibility with build environments using Busybox.
>
> Fixes: 973eca8db557 ("kbuild: mksysmap now works on nixos")
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Thanks! Fixes the build on my nix system as well.
Tested-by: Dmitry Safonov <0x7f454c46@gmail.com>
> ---
> scripts/link-vmlinux.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 46ce5d04dbeb..518c70b8db50 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -193,7 +193,7 @@ kallsyms_step()
> mksysmap()
> {
> info NM ${2}
> - ${NM} -n "${1}" | "${srctree}/scripts/mksysmap" > "${2}"
> + ${NM} -n "${1}" | sed -f "${srctree}/scripts/mksysmap" > "${2}"
> }
>
> sorttable()
prev parent reply other threads:[~2024-06-06 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 3:49 [PATCH -next] kbuild: explicitly run mksysmap as sed script from link-vmlinux.sh Richard Acayan
2024-06-05 5:45 ` Masahiro Yamada
2024-06-05 13:05 ` Masahiro Yamada
2024-06-05 13:07 ` Kent Overstreet
2024-06-05 17:56 ` Richard Acayan
2024-06-06 23:14 ` Dmitry Safonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606231422.57599-1-0x7f454c46@gmail.com \
--to=0x7f454c46@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-kbuild@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox