Re: [PATCH -next] kbuild: explicitly run mksysmap as sed script from link-vmlinux.sh

[Richard Acayan <mailingradian@gmail.com>]

On Wed, Jun 05, 2024 at 09:07:26AM -0400, Kent Overstreet wrote:
> On Wed, Jun 05, 2024 at 10:05:22PM +0900, Masahiro Yamada wrote:
> > On Wed, Jun 5, 2024 at 12:49 PM Richard Acayan <mailingradian@gmail.com> wrote:
> > >
> > > In commit b18b047002b7 ("kbuild: change scripts/mksysmap into sed
> > > script"), the mksysmap script was transformed into a sed script,
> > > made directly executable with "#!/bin/sed -f". Apparently, the path to
> > > sed is different on NixOS, fixed by using the env command.
> > >
> > > To accommodate the number of arguments above the normal maximum for
> > > hashbangs, the -S flag of env was used (as in
> > > "#!/usr/bin/env -S sed -f"). However, env -S is a GNU extension.
> > > Explicitly use sed instead of relying on the executable shebang to keep
> > > compatibility with build environments using Busybox.
> > 
> > 
> > I am fine with the code.
> > 
> > Kent will drop his local commit, so please reword the commit description
> > without 973eca8db557 in mind.
> 
> Sorry for the hassle - glad this is fixed

All good :). I'm just happy that the maintainers are still listening to
developers compiling linux-next on Alpine Linux.

You can optionally attach a reporter tag in v2 since you reported the
original bug.