public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Sami Tolvanen <samitolvanen@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	 Miguel Ojeda <ojeda@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Matthew Maurer <mmaurer@google.com>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	 Wedson Almeida Filho <wedsonaf@gmail.com>,
	Gary Guo <gary@garyguo.net>, Petr Pavlu <petr.pavlu@suse.com>,
	 Neal Gompa <neal@gompa.dev>, Hector Martin <marcan@marcan.st>,
	Janne Grunau <j@jannau.net>,  Asahi Linux <asahi@lists.linux.dev>,
	linux-kbuild@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-modules@vger.kernel.org,  rust-for-linux@vger.kernel.org,
	Sami Tolvanen <samitolvanen@google.com>
Subject: [PATCH v2 09/19] gendwarfksyms: Expand array_type
Date: Thu, 15 Aug 2024 17:39:13 +0000	[thread overview]
Message-ID: <20240815173903.4172139-30-samitolvanen@google.com> (raw)
In-Reply-To: <20240815173903.4172139-21-samitolvanen@google.com>

Add support for expanding DW_TAG_array_type, and the subrange type
indicating array size.

Example source code:

  const char *s[34];

Output with --debug:

  variable array_type [34] {
    pointer_type <unnamed> {
      const_type <unnamed> {
        base_type char byte_size(1) encoding(6)
      }
    } byte_size(8)
  };

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
---
 scripts/gendwarfksyms/dwarf.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/scripts/gendwarfksyms/dwarf.c b/scripts/gendwarfksyms/dwarf.c
index c81652426be8..4ec69fce95f3 100644
--- a/scripts/gendwarfksyms/dwarf.c
+++ b/scripts/gendwarfksyms/dwarf.c
@@ -218,6 +218,7 @@ DEFINE_PROCESS_UDATA_ATTRIBUTE(encoding)
 	}
 
 DEFINE_MATCH(formal_parameter)
+DEFINE_MATCH(subrange)
 
 bool match_all(Dwarf_Die *die)
 {
@@ -309,6 +310,34 @@ DEFINE_PROCESS_TYPE(shared)
 DEFINE_PROCESS_TYPE(volatile)
 DEFINE_PROCESS_TYPE(typedef)
 
+static int process_subrange_type(struct state *state, struct die *cache,
+				 Dwarf_Die *die)
+{
+	Dwarf_Word count = 0;
+
+	if (get_udata_attr(die, DW_AT_count, &count))
+		return check(process_fmt(state, cache, "[%" PRIu64 "]", count));
+	if (get_udata_attr(die, DW_AT_upper_bound, &count))
+		return check(
+			process_fmt(state, cache, "[%" PRIu64 "]", count + 1));
+
+	return check(process(state, cache, "[]"));
+}
+
+static int process_array_type(struct state *state, struct die *cache,
+			      Dwarf_Die *die)
+{
+	check(process(state, cache, "array_type "));
+	/* Array size */
+	check(process_die_container(state, cache, die, process_type,
+				    match_subrange_type));
+	check(process(state, cache, " {"));
+	check(process_linebreak(cache, 1));
+	check(process_type_attr(state, cache, die));
+	check(process_linebreak(cache, -1));
+	return check(process(state, cache, "}"));
+}
+
 static int __process_subroutine_type(struct state *state, struct die *cache,
 				     Dwarf_Die *die, const char *type)
 {
@@ -411,7 +440,9 @@ static int process_type(struct state *state, struct die *parent, Dwarf_Die *die)
 	PROCESS_TYPE(volatile)
 	/* Subtypes */
 	PROCESS_TYPE(formal_parameter)
+	PROCESS_TYPE(subrange)
 	/* Other types */
+	PROCESS_TYPE(array)
 	PROCESS_TYPE(base)
 	PROCESS_TYPE(subroutine)
 	PROCESS_TYPE(typedef)
-- 
2.46.0.184.g6999bdac58-goog


  parent reply	other threads:[~2024-08-15 17:39 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 17:39 [PATCH v2 00/19] Implement DWARF modversions Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 01/19] tools: Add gendwarfksyms Sami Tolvanen
2024-08-16  7:14   ` Greg Kroah-Hartman
2024-08-27 16:44     ` Sami Tolvanen
2024-08-26 17:41   ` Petr Pavlu
2024-08-26 18:47     ` Sami Tolvanen
2024-08-28 12:31       ` Petr Pavlu
2024-08-28 21:28         ` Sami Tolvanen
2024-08-28 17:45   ` Masahiro Yamada
2024-08-28 21:32     ` Sami Tolvanen
2024-09-05  2:29   ` Masahiro Yamada
2024-09-05 20:52     ` Sami Tolvanen
2024-09-10  9:43       ` Masahiro Yamada
2024-09-10 21:09         ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 02/19] gendwarfksyms: Add symbol list handling Sami Tolvanen
2024-08-27  9:16   ` Petr Pavlu
2024-08-27 18:47     ` Sami Tolvanen
2024-08-28 12:35   ` Petr Pavlu
2024-08-28 23:09     ` Sami Tolvanen
2024-09-02  9:52       ` Petr Pavlu
2024-08-28 18:16   ` Masahiro Yamada
2024-08-28 21:50     ` Sami Tolvanen
2024-09-01 10:59   ` Masahiro Yamada
2024-09-04 20:51     ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 03/19] gendwarfksyms: Add address matching Sami Tolvanen
2024-08-27 12:40   ` Petr Pavlu
2024-08-27 21:28     ` Sami Tolvanen
2024-08-28 18:22   ` Masahiro Yamada
2024-08-28 21:56     ` Sami Tolvanen
2024-09-01 11:10   ` Masahiro Yamada
2024-09-04 20:48     ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 04/19] gendwarfksyms: Add support for type pointers Sami Tolvanen
2024-08-28  6:50   ` Masahiro Yamada
2024-08-28  7:15     ` Masahiro Yamada
2024-08-28 21:58       ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 05/19] gendwarfksyms: Expand base_type Sami Tolvanen
2024-08-28 12:46   ` Petr Pavlu
2024-08-28 22:19     ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 06/19] gendwarfksyms: Add a cache for processed DIEs Sami Tolvanen
2024-08-28 18:15   ` Masahiro Yamada
2024-08-28 22:27     ` Sami Tolvanen
2024-09-02 10:05   ` Petr Pavlu
2024-09-05 17:19     ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 07/19] gendwarfksyms: Expand type modifiers and typedefs Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 08/19] gendwarfksyms: Expand subroutine_type Sami Tolvanen
2024-09-03 15:11   ` Petr Pavlu
2024-09-05 17:22     ` Sami Tolvanen
2024-08-15 17:39 ` Sami Tolvanen [this message]
2024-08-15 17:39 ` [PATCH v2 10/19] gendwarfksyms: Expand structure types Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 11/19] gendwarfksyms: Limit structure expansion Sami Tolvanen
2024-09-03 15:15   ` Petr Pavlu
2024-09-05 18:15     ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 12/19] gendwarfksyms: Add die_map debugging Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 13/19] gendwarfksyms: Add symtypes output Sami Tolvanen
2024-09-10 14:58   ` Petr Pavlu
2024-09-10 21:15     ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 14/19] gendwarfksyms: Add symbol versioning Sami Tolvanen
2024-09-11 10:08   ` Petr Pavlu
2024-09-11 16:03     ` Sami Tolvanen
2024-09-12 10:28       ` Petr Pavlu
2024-08-15 17:39 ` [PATCH v2 15/19] gendwarfksyms: Add support for declaration-only data structures Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 16/19] gendwarfksyms: Add support for reserved structure fields Sami Tolvanen
2024-08-16  7:20   ` Greg Kroah-Hartman
2024-08-16 15:50     ` Sami Tolvanen
2024-08-17  7:41       ` Greg Kroah-Hartman
2024-08-17 13:19         ` Benno Lossin
2024-08-19 18:25           ` Greg Kroah-Hartman
2024-08-19 21:46             ` Benno Lossin
2024-08-19 19:38           ` Sami Tolvanen
2024-08-19 22:16             ` Benno Lossin
2024-08-20 18:47               ` Sami Tolvanen
2024-08-20 20:03                 ` Matthew Maurer
2024-08-21 11:31                   ` Benno Lossin
2024-08-21 23:01                     ` Sami Tolvanen
2024-08-21 23:29                     ` Greg Kroah-Hartman
2024-08-22  5:55                       ` Benno Lossin
2024-08-22  7:29                         ` Greg Kroah-Hartman
2024-08-22 12:00                           ` Benno Lossin
2024-08-22 23:53                             ` Greg Kroah-Hartman
2024-08-23 19:17                               ` Sami Tolvanen
2024-08-24 13:29                                 ` Benno Lossin
2024-08-24 13:27                               ` Benno Lossin
2024-08-30  9:34   ` Miroslav Benes
2024-08-31  0:05     ` Sami Tolvanen
2024-09-11 11:43       ` Petr Pavlu
2024-09-12 16:06         ` Sami Tolvanen
2024-09-12 18:08           ` Benno Lossin
2024-09-12 20:58             ` Sami Tolvanen
2024-09-12 21:58               ` Benno Lossin
2024-09-12 22:37                 ` Sami Tolvanen
2024-09-13  8:00                   ` Benno Lossin
2024-08-15 17:39 ` [PATCH v2 17/19] export: Add __gendwarfksyms_ptr_ references to exported symbols Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 18/19] x86/asm-prototypes: Include <asm/ptrace.h> Sami Tolvanen
2024-09-01 10:50   ` Masahiro Yamada
2024-09-04 20:47     ` Sami Tolvanen
2024-08-15 17:39 ` [PATCH v2 19/19] kbuild: Add gendwarfksyms as an alternative to genksyms Sami Tolvanen
2024-08-15 20:13 ` [PATCH v2 00/19] Implement DWARF modversions Sedat Dilek
2024-08-15 20:47   ` Sami Tolvanen
2024-08-21  0:12     ` Sedat Dilek
2024-08-16  7:15 ` Greg Kroah-Hartman
2024-08-22 16:43 ` Jonathan Corbet
2024-08-22 17:57   ` Sami Tolvanen
2024-08-28  7:04 ` Masahiro Yamada
2024-08-28 22:53   ` Sami Tolvanen
2024-09-02  9:57     ` Petr Pavlu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240815173903.4172139-30-samitolvanen@google.com \
    --to=samitolvanen@google.com \
    --cc=alex.gaynor@gmail.com \
    --cc=asahi@lists.linux.dev \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=j@jannau.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mmaurer@google.com \
    --cc=neal@gompa.dev \
    --cc=ojeda@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox