* [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2
@ 2025-06-12 16:08 Masahiro Yamada
2025-06-12 16:16 ` Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Masahiro Yamada @ 2025-06-12 16:08 UTC (permalink / raw)
To: linux-kbuild
Cc: Arnd Bergmann, Heiko Carstens, Sean Christopherson,
Masahiro Yamada, Nathan Chancellor, Nicolas Schier, linux-kernel
This hides excessive warnings, as nobody builds with W=2.
Fixes: a934a57a42f6 ("scripts/misc-check: check missing #include <linux/export.h> when W=1")
Fixes: 7d95680d64ac ("scripts/misc-check: check unnecessary #include <linux/export.h> when W=1")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 3 ---
scripts/misc-check | 15 ++++++++++++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 35e6e5240c61..69c534982415 100644
--- a/Makefile
+++ b/Makefile
@@ -1832,12 +1832,9 @@ rustfmtcheck: rustfmt
# Misc
# ---------------------------------------------------------------------------
-# Run misc checks when ${KBUILD_EXTRA_WARN} contains 1
PHONY += misc-check
-ifneq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
misc-check:
$(Q)$(srctree)/scripts/misc-check
-endif
all: misc-check
diff --git a/scripts/misc-check b/scripts/misc-check
index a74450e799d1..84f08da17b2c 100755
--- a/scripts/misc-check
+++ b/scripts/misc-check
@@ -62,6 +62,15 @@ check_unnecessary_include_linux_export_h () {
xargs -r printf "%s: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present\n" >&2
}
-check_tracked_ignored_files
-check_missing_include_linux_export_h
-check_unnecessary_include_linux_export_h
+case "${KBUILD_EXTRA_WARN}" in
+*1*)
+ check_tracked_ignored_files
+ ;;
+esac
+
+case "${KBUILD_EXTRA_WARN}" in
+*2*)
+ check_missing_include_linux_export_h
+ check_unnecessary_include_linux_export_h
+ ;;
+esac
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2
2025-06-12 16:08 [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2 Masahiro Yamada
@ 2025-06-12 16:16 ` Arnd Bergmann
2025-06-12 18:15 ` Nathan Chancellor
2025-06-13 7:34 ` Heiko Carstens
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2025-06-12 16:16 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild
Cc: Heiko Carstens, Sean Christopherson, Nathan Chancellor,
Nicolas Schier, linux-kernel
On Thu, Jun 12, 2025, at 18:08, Masahiro Yamada wrote:
> This hides excessive warnings, as nobody builds with W=2.
>
> Fixes: a934a57a42f6 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1")
> Fixes: 7d95680d64ac ("scripts/misc-check: check unnecessary #include
> <linux/export.h> when W=1")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2
2025-06-12 16:08 [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2 Masahiro Yamada
2025-06-12 16:16 ` Arnd Bergmann
@ 2025-06-12 18:15 ` Nathan Chancellor
2025-06-13 7:34 ` Heiko Carstens
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2025-06-12 18:15 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, Arnd Bergmann, Heiko Carstens, Sean Christopherson,
Nicolas Schier, linux-kernel
On Fri, Jun 13, 2025 at 01:08:48AM +0900, Masahiro Yamada wrote:
> This hides excessive warnings, as nobody builds with W=2.
>
> Fixes: a934a57a42f6 ("scripts/misc-check: check missing #include <linux/export.h> when W=1")
> Fixes: 7d95680d64ac ("scripts/misc-check: check unnecessary #include <linux/export.h> when W=1")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
>
> Makefile | 3 ---
> scripts/misc-check | 15 ++++++++++++---
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 35e6e5240c61..69c534982415 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1832,12 +1832,9 @@ rustfmtcheck: rustfmt
> # Misc
> # ---------------------------------------------------------------------------
>
> -# Run misc checks when ${KBUILD_EXTRA_WARN} contains 1
> PHONY += misc-check
> -ifneq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
> misc-check:
> $(Q)$(srctree)/scripts/misc-check
> -endif
>
> all: misc-check
>
> diff --git a/scripts/misc-check b/scripts/misc-check
> index a74450e799d1..84f08da17b2c 100755
> --- a/scripts/misc-check
> +++ b/scripts/misc-check
> @@ -62,6 +62,15 @@ check_unnecessary_include_linux_export_h () {
> xargs -r printf "%s: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present\n" >&2
> }
>
> -check_tracked_ignored_files
> -check_missing_include_linux_export_h
> -check_unnecessary_include_linux_export_h
> +case "${KBUILD_EXTRA_WARN}" in
> +*1*)
> + check_tracked_ignored_files
> + ;;
> +esac
> +
> +case "${KBUILD_EXTRA_WARN}" in
> +*2*)
> + check_missing_include_linux_export_h
> + check_unnecessary_include_linux_export_h
> + ;;
> +esac
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2
2025-06-12 16:08 [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2 Masahiro Yamada
2025-06-12 16:16 ` Arnd Bergmann
2025-06-12 18:15 ` Nathan Chancellor
@ 2025-06-13 7:34 ` Heiko Carstens
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Carstens @ 2025-06-13 7:34 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, Arnd Bergmann, Sean Christopherson,
Nathan Chancellor, Nicolas Schier, linux-kernel
On Fri, Jun 13, 2025 at 01:08:48AM +0900, Masahiro Yamada wrote:
> This hides excessive warnings, as nobody builds with W=2.
>
> Fixes: a934a57a42f6 ("scripts/misc-check: check missing #include <linux/export.h> when W=1")
> Fixes: 7d95680d64ac ("scripts/misc-check: check unnecessary #include <linux/export.h> when W=1")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Makefile | 3 ---
> scripts/misc-check | 15 ++++++++++++---
> 2 files changed, 12 insertions(+), 6 deletions(-)
Thank you!
Acked-by: Heiko Carstens <hca@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-13 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-12 16:08 [PATCH] kbuild: move warnings about linux/export.h from W=1 to W=2 Masahiro Yamada
2025-06-12 16:16 ` Arnd Bergmann
2025-06-12 18:15 ` Nathan Chancellor
2025-06-13 7:34 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox