* [PATCH v3 5/5] kbuild: Allow adding modules into the FIT ramdisk [not found] <20250922224835.1918759-1-sjg@chromium.org> @ 2025-09-22 22:48 ` Simon Glass 2025-09-22 23:07 ` Randy Dunlap 2025-09-24 16:54 ` Nathan Chancellor 0 siblings, 2 replies; 4+ messages in thread From: Simon Glass @ 2025-09-22 22:48 UTC (permalink / raw) To: linux-arm-kernel Cc: Nicolas Schier, Tom Rini, Ahmad Fatoum, J . Neuschäfer, Masahiro Yamada, Chen-Yu Tsai, Simon Glass, Ard Biesheuvel, Han Shen, Josh Poimboeuf, Kees Cook, Nathan Chancellor, Nicolas Schier, Rong Xu, linux-kbuild, linux-kernel Support 'make image.fit FIT_MODULES=1' to put all the modules into a ramdisk image within the FIT. Signed-off-by: Simon Glass <sjg@chromium.org> Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- (no changes since v1) scripts/Makefile.lib | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 1d581ba5df66..2e880d9b4706 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -398,9 +398,15 @@ MAKE_FIT := $(srctree)/scripts/make_fit.py # Use this to override the compression algorithm FIT_COMPRESSION ?= gzip +# Set this to 1 to include an initrd with all the kernel modules +FIT_MODULES ?= 0 +ifeq ($(FIT_MODULES),1) +EXTRA := -B $(objtree) -m +endif + quiet_cmd_fit = FIT $@ cmd_fit = $(MAKE_FIT) -o $@ --arch $(UIMAGE_ARCH) --os linux \ - --name '$(UIMAGE_NAME)' \ + --name '$(UIMAGE_NAME)' $(EXTRA) \ $(if $(findstring 1,$(KBUILD_VERBOSE)),-v) \ $(if $(FIT_DECOMPOSE_DTBS),--decompose-dtbs) \ --compress $(FIT_COMPRESSION) -k $< @$(word 2,$^) -- 2.43.0 base-commit: 846bd2225ec3cfa8be046655e02b9457ed41973e branch: fita3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 5/5] kbuild: Allow adding modules into the FIT ramdisk 2025-09-22 22:48 ` [PATCH v3 5/5] kbuild: Allow adding modules into the FIT ramdisk Simon Glass @ 2025-09-22 23:07 ` Randy Dunlap 2025-09-23 11:41 ` Simon Glass 2025-09-24 16:54 ` Nathan Chancellor 1 sibling, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2025-09-22 23:07 UTC (permalink / raw) To: Simon Glass, linux-arm-kernel Cc: Nicolas Schier, Tom Rini, Ahmad Fatoum, J . Neuschäfer, Masahiro Yamada, Chen-Yu Tsai, Ard Biesheuvel, Han Shen, Josh Poimboeuf, Kees Cook, Nathan Chancellor, Nicolas Schier, Rong Xu, linux-kbuild, linux-kernel Hi, On 9/22/25 3:48 PM, Simon Glass wrote: > Support 'make image.fit FIT_MODULES=1' to put all the modules into a > ramdisk image within the FIT. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > --- Regarding $subject, a comment in scripts/make_fit.py says: Note that this tool does not yet support adding a ramdisk / initrd. Is the comment incorrect or are you changing that feature here? Thanks. > > (no changes since v1) > > scripts/Makefile.lib | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 1d581ba5df66..2e880d9b4706 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -398,9 +398,15 @@ MAKE_FIT := $(srctree)/scripts/make_fit.py > # Use this to override the compression algorithm > FIT_COMPRESSION ?= gzip > > +# Set this to 1 to include an initrd with all the kernel modules > +FIT_MODULES ?= 0 > +ifeq ($(FIT_MODULES),1) > +EXTRA := -B $(objtree) -m > +endif > + > quiet_cmd_fit = FIT $@ > cmd_fit = $(MAKE_FIT) -o $@ --arch $(UIMAGE_ARCH) --os linux \ > - --name '$(UIMAGE_NAME)' \ > + --name '$(UIMAGE_NAME)' $(EXTRA) \ > $(if $(findstring 1,$(KBUILD_VERBOSE)),-v) \ > $(if $(FIT_DECOMPOSE_DTBS),--decompose-dtbs) \ > --compress $(FIT_COMPRESSION) -k $< @$(word 2,$^) -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 5/5] kbuild: Allow adding modules into the FIT ramdisk 2025-09-22 23:07 ` Randy Dunlap @ 2025-09-23 11:41 ` Simon Glass 0 siblings, 0 replies; 4+ messages in thread From: Simon Glass @ 2025-09-23 11:41 UTC (permalink / raw) To: Randy Dunlap Cc: linux-arm-kernel, Nicolas Schier, Tom Rini, Ahmad Fatoum, J . Neuschäfer, Masahiro Yamada, Chen-Yu Tsai, Ard Biesheuvel, Han Shen, Josh Poimboeuf, Kees Cook, Nathan Chancellor, Nicolas Schier, Rong Xu, linux-kbuild, linux-kernel Hi Randy, On Mon, 22 Sept 2025 at 17:08, Randy Dunlap <rdunlap@infradead.org> wrote: > > Hi, > > On 9/22/25 3:48 PM, Simon Glass wrote: > > Support 'make image.fit FIT_MODULES=1' to put all the modules into a > > ramdisk image within the FIT. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > > --- > > Regarding $subject, a comment in scripts/make_fit.py says: > > Note that this tool does not yet support adding a ramdisk / initrd. > > Is the comment incorrect or are you changing that feature here? I am changing it (in patch 2 of this series). Regards, Simon > > Thanks. > > > > > (no changes since v1) > > > > scripts/Makefile.lib | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > > index 1d581ba5df66..2e880d9b4706 100644 > > --- a/scripts/Makefile.lib > > +++ b/scripts/Makefile.lib > > @@ -398,9 +398,15 @@ MAKE_FIT := $(srctree)/scripts/make_fit.py > > # Use this to override the compression algorithm > > FIT_COMPRESSION ?= gzip > > > > +# Set this to 1 to include an initrd with all the kernel modules > > +FIT_MODULES ?= 0 > > +ifeq ($(FIT_MODULES),1) > > +EXTRA := -B $(objtree) -m > > +endif > > + > > quiet_cmd_fit = FIT $@ > > cmd_fit = $(MAKE_FIT) -o $@ --arch $(UIMAGE_ARCH) --os linux \ > > - --name '$(UIMAGE_NAME)' \ > > + --name '$(UIMAGE_NAME)' $(EXTRA) \ > > $(if $(findstring 1,$(KBUILD_VERBOSE)),-v) \ > > $(if $(FIT_DECOMPOSE_DTBS),--decompose-dtbs) \ > > --compress $(FIT_COMPRESSION) -k $< @$(word 2,$^) > > -- > ~Randy > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 5/5] kbuild: Allow adding modules into the FIT ramdisk 2025-09-22 22:48 ` [PATCH v3 5/5] kbuild: Allow adding modules into the FIT ramdisk Simon Glass 2025-09-22 23:07 ` Randy Dunlap @ 2025-09-24 16:54 ` Nathan Chancellor 1 sibling, 0 replies; 4+ messages in thread From: Nathan Chancellor @ 2025-09-24 16:54 UTC (permalink / raw) To: Simon Glass Cc: linux-arm-kernel, Nicolas Schier, Tom Rini, Ahmad Fatoum, J . Neuschäfer, Masahiro Yamada, Chen-Yu Tsai, Ard Biesheuvel, Han Shen, Josh Poimboeuf, Kees Cook, Nicolas Schier, Rong Xu, linux-kbuild, linux-kernel On Mon, Sep 22, 2025 at 04:48:32PM -0600, Simon Glass wrote: > Support 'make image.fit FIT_MODULES=1' to put all the modules into a > ramdisk image within the FIT. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > --- Acked-by: Nathan Chancellor <nathan@kernel.org> > scripts/Makefile.lib | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 1d581ba5df66..2e880d9b4706 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -398,9 +398,15 @@ MAKE_FIT := $(srctree)/scripts/make_fit.py > # Use this to override the compression algorithm > FIT_COMPRESSION ?= gzip > > +# Set this to 1 to include an initrd with all the kernel modules > +FIT_MODULES ?= 0 > +ifeq ($(FIT_MODULES),1) > +EXTRA := -B $(objtree) -m Not that I can imagine it being a big issue, it would be nice to potentially namespace this variable, like MAKE_FIT_EXTRA or MAKE_FIT_FLAGS? > +endif > + > quiet_cmd_fit = FIT $@ > cmd_fit = $(MAKE_FIT) -o $@ --arch $(UIMAGE_ARCH) --os linux \ > - --name '$(UIMAGE_NAME)' \ > + --name '$(UIMAGE_NAME)' $(EXTRA) \ > $(if $(findstring 1,$(KBUILD_VERBOSE)),-v) \ > $(if $(FIT_DECOMPOSE_DTBS),--decompose-dtbs) \ > --compress $(FIT_COMPRESSION) -k $< @$(word 2,$^) > -- > 2.43.0 > > base-commit: 846bd2225ec3cfa8be046655e02b9457ed41973e > branch: fita3 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-24 16:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250922224835.1918759-1-sjg@chromium.org>
2025-09-22 22:48 ` [PATCH v3 5/5] kbuild: Allow adding modules into the FIT ramdisk Simon Glass
2025-09-22 23:07 ` Randy Dunlap
2025-09-23 11:41 ` Simon Glass
2025-09-24 16:54 ` Nathan Chancellor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox