From: Nathan Chancellor <nathan@kernel.org>
To: Jill Ravaliya <jillravaliya@gmail.com>
Cc: nsc@kernel.org, masahiroy@kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: deb-pkg: propagate hook script failures in builddeb
Date: Sun, 17 May 2026 13:29:52 +0900 [thread overview]
Message-ID: <20260517042952.GB1534263@ax162> (raw)
In-Reply-To: <20260516071643.23179-1-jillravaliya@gmail.com>
Hi Jill,
On Sat, May 16, 2026 at 12:45:44PM +0530, Jill Ravaliya wrote:
> Hi Nathan, Nicolas,
>
> You are correct. I tested locally and confirmed that
> set -e in the generated postinst does catch run-parts
> failures even in the && expression — execution does
> not reach exit 0 when run-parts fails.
>
> My patch is therefore redundant. I am withdrawing it.
>
> The root cause remains 55-initrd.install silently
> returning exit 0 when initrd is missing (LP#2141741),
> which run-parts sees as success. That is where the
> fix belongs.
Thanks for confirming!
> This was my first patch to the kernel mailing list.
> I apologize for the noise and thank you both for
> taking the time to review it carefully.
No apologies necessary, it is all part of learning :) thanks for
attempting to improve the usability of the Debian packaging.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-05-17 4:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 7:15 [PATCH] kbuild: deb-pkg: propagate hook script failures in builddeb Jill Ravaliya
2026-05-17 4:29 ` Nathan Chancellor [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-08 10:27 Jill Ravaliya
2026-05-08 12:01 ` Nathan Chancellor
2026-05-08 10:18 Jill Ravaliya
2026-04-22 18:30 Jill Ravaliya
2026-04-22 22:06 ` Nathan Chancellor
2026-04-30 8:54 ` Jill Ravaliya
2026-04-30 22:52 ` Nathan Chancellor
2026-05-01 1:20 ` Jill Ravaliya
2026-05-15 19:30 ` Nicolas Schier
2026-05-15 19:53 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517042952.GB1534263@ax162 \
--to=nathan@kernel.org \
--cc=jillravaliya@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox