From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: Jill Ravaliya <jillravaliya@gmail.com>,
masahiroy@kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: deb-pkg: propagate hook script failures in builddeb
Date: Sat, 16 May 2026 04:53:39 +0900 [thread overview]
Message-ID: <20260515195339.GA553537@ax162> (raw)
In-Reply-To: <agd0Ta6zFgtzXQkc@levanger>
On Fri, May 15, 2026 at 09:30:21PM +0200, Nicolas Schier wrote:
> On Fri, May 01, 2026 at 06:50:18AM +0530, Jill Ravaliya wrote:
> > The 'builddeb' script generates maintainer scripts for Debian-based
> > distributions. Currently, it invokes post-installation hooks via
> > run-parts but unconditionally exits with code 0.
>
> Are you sure? On my Debian trixie, run-parts exits with 1 as soon as a
> single script from the given directory exists with non-zero.
...
> > This patch ensures that failures in 'run-parts' are correctly
> > propagated, allowing the package manager to abort the installation
> > upon hook failure.
Hmmm, yeah, I had missed the 'set -e' in this script, so I think this
change should be unnecessary because run-parts failures should already
be propagated up from 'set -e'. If a script in /{etc,usr/share}/kernel
does not error when it should, there is nothing we can do about that
(which appears to be the cause of the original issue). Thanks for the
review!
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-05-15 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 18:30 [PATCH] kbuild: deb-pkg: propagate hook script failures in builddeb Jill Ravaliya
2026-04-22 22:06 ` Nathan Chancellor
2026-04-30 8:54 ` Jill Ravaliya
2026-04-30 22:52 ` Nathan Chancellor
2026-05-01 1:20 ` Jill Ravaliya
2026-05-15 19:30 ` Nicolas Schier
2026-05-15 19:53 ` Nathan Chancellor [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-08 10:18 Jill Ravaliya
2026-05-08 10:27 Jill Ravaliya
2026-05-08 12:01 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515195339.GA553537@ax162 \
--to=nathan@kernel.org \
--cc=jillravaliya@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox