kbuild: mksysmap: Build regression for next-20240604

kbuild: mksysmap: Build regression for next-20240604

[Jon Hunter]

Hi Kent,

Since next-20240604 I noticed a build regression in our farm builders
and I am seeing the following error ...

/usr/bin/env: invalid option -- 'S'
Try '/usr/bin/env --help' for more information.

These builders have an older version of 'env' that do not support the
'-S' argument and so your change [0] is breaking the for these
machines. I did not see your patch on any list and found it on your
bcachefs tree [1]. So not clear if this has been reviewed and if this
is trying to fix some related to Masahiro change [2]?

It is also not clear what the minimum version of 'env' is supported
for building the linux kernel, but these builders have been building
the kernel fine for years.

Thanks
Jon

[0] https://evilpiepirate.org/git/bcachefs.git/commit/?h=for-next&id=973eca8db5570dd0c3f2b3190867138cc446eb3b
[1] https://evilpiepirate.org/git/bcachefs.git/log/?h=for-next
[2] https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=kbuild&id=b18b047002b7d3b19d9fb905c1bd2a214016c153

Re: kbuild: mksysmap: Build regression for next-20240604

[Kent Overstreet]

On Wed, Jun 05, 2024 at 09:14:23AM +0100, Jon Hunter wrote:
> Hi Kent,
> 
> Since next-20240604 I noticed a build regression in our farm builders
> and I am seeing the following error ...
> 
> /usr/bin/env: invalid option -- 'S'
> Try '/usr/bin/env --help' for more information.
> 
> These builders have an older version of 'env' that do not support the
> '-S' argument and so your change [0] is breaking the for these
> machines. I did not see your patch on any list and found it on your
> bcachefs tree [1]. So not clear if this has been reviewed and if this
> is trying to fix some related to Masahiro change [2]?
> 
> It is also not clear what the minimum version of 'env' is supported
> for building the linux kernel, but these builders have been building
> the kernel fine for years.
> 
> Thanks
> Jon
> 
> [0] https://evilpiepirate.org/git/bcachefs.git/commit/?h=for-next&id=973eca8db5570dd0c3f2b3190867138cc446eb3b
> [1] https://evilpiepirate.org/git/bcachefs.git/log/?h=for-next
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=kbuild&id=b18b047002b7d3b19d9fb905c1bd2a214016c153

I'll drop it, but we need a real fix then, my CI builders are broken
without it...

Re: kbuild: mksysmap: Build regression for next-20240604

[Masahiro Yamada]

On Wed, Jun 5, 2024 at 9:56 PM Kent Overstreet
<kent.overstreet@linux.dev> wrote:
>
> On Wed, Jun 05, 2024 at 09:14:23AM +0100, Jon Hunter wrote:
> > Hi Kent,
> >
> > Since next-20240604 I noticed a build regression in our farm builders
> > and I am seeing the following error ...
> >
> > /usr/bin/env: invalid option -- 'S'
> > Try '/usr/bin/env --help' for more information.
> >
> > These builders have an older version of 'env' that do not support the
> > '-S' argument and so your change [0] is breaking the for these
> > machines. I did not see your patch on any list and found it on your
> > bcachefs tree [1]. So not clear if this has been reviewed and if this
> > is trying to fix some related to Masahiro change [2]?
> >
> > It is also not clear what the minimum version of 'env' is supported
> > for building the linux kernel, but these builders have been building
> > the kernel fine for years.
> >
> > Thanks
> > Jon
> >
> > [0] https://evilpiepirate.org/git/bcachefs.git/commit/?h=for-next&id=973eca8db5570dd0c3f2b3190867138cc446eb3b
> > [1] https://evilpiepirate.org/git/bcachefs.git/log/?h=for-next
> > [2] https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=kbuild&id=b18b047002b7d3b19d9fb905c1bd2a214016c153
>
> I'll drop it, but we need a real fix then, my CI builders are broken
> without it...




I will apply Richard's patch instead and send a pull request for -rc3.

https://lore.kernel.org/linux-kbuild/CAK7LNASx_iSWZ14W5dpTOM87kB8A-Paq8fM_3nKH5tdfJQ7+ZQ@mail.gmail.com/T/#mfa8b89c64a6a14a764338e9398d40be9bc48cdf1






-- 
Best Regards
Masahiro Yamada

Re: kbuild: mksysmap: Build regression for next-20240604

[Jon Hunter]

On 05/06/2024 14:02, Masahiro Yamada wrote:
> On Wed, Jun 5, 2024 at 9:56 PM Kent Overstreet
> <kent.overstreet@linux.dev> wrote:
>>
>> On Wed, Jun 05, 2024 at 09:14:23AM +0100, Jon Hunter wrote:
>>> Hi Kent,
>>>
>>> Since next-20240604 I noticed a build regression in our farm builders
>>> and I am seeing the following error ...
>>>
>>> /usr/bin/env: invalid option -- 'S'
>>> Try '/usr/bin/env --help' for more information.
>>>
>>> These builders have an older version of 'env' that do not support the
>>> '-S' argument and so your change [0] is breaking the for these
>>> machines. I did not see your patch on any list and found it on your
>>> bcachefs tree [1]. So not clear if this has been reviewed and if this
>>> is trying to fix some related to Masahiro change [2]?
>>>
>>> It is also not clear what the minimum version of 'env' is supported
>>> for building the linux kernel, but these builders have been building
>>> the kernel fine for years.
>>>
>>> Thanks
>>> Jon
>>>
>>> [0] https://evilpiepirate.org/git/bcachefs.git/commit/?h=for-next&id=973eca8db5570dd0c3f2b3190867138cc446eb3b
>>> [1] https://evilpiepirate.org/git/bcachefs.git/log/?h=for-next
>>> [2] https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=kbuild&id=b18b047002b7d3b19d9fb905c1bd2a214016c153
>>
>> I'll drop it, but we need a real fix then, my CI builders are broken
>> without it...

Proper fixes are always good so that everyone's CI builders work :-)

> I will apply Richard's patch instead and send a pull request for -rc3.
> 
> https://lore.kernel.org/linux-kbuild/CAK7LNASx_iSWZ14W5dpTOM87kB8A-Paq8fM_3nKH5tdfJQ7+ZQ@mail.gmail.com/T/#mfa8b89c64a6a14a764338e9398d40be9bc48cdf1

Works for me!

Thanks
Jon

-- 
nvpublic