From: Michal Marek <mmarek@suse.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: Matthias Schniedermeyer <ms@citd.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Sam Ravnborg <sam@ravnborg.org>,
Sasha Levin <levinsasha928@gmail.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] config: Add 'make kvmconfig'
Date: Wed, 02 Nov 2011 10:07:27 +0100 [thread overview]
Message-ID: <4EB1084F.4020206@suse.cz> (raw)
In-Reply-To: <20111102084124.GB18771@elte.hu>
On 2.11.2011 09:41, Ingo Molnar wrote:
>
> * Matthias Schniedermeyer <ms@citd.de> wrote:
>
>> And AFAICS there currently is no "modconfig", only an
>> "allmodconfig" (and "localmodconfig")
>>
>> With no letters dropped it would be less ambiguous. make
>> modifyconfig=kvm
>
> Yeah. Note that it's more like an 'add' operation, not a modify
> operation, thus:
>
> make addconfig=kvm
>
> or:
>
> make addconfig kvm
>
> would be intuitive and would work well too.
>
> Sam, Michal, which one would you prefer? The latter might have the
> advantage that it's additive, enabling future usages like:
>
> make addconfig kvm debug
The problem is that neither of these fit into the make command syntax:
make addconfig kvm debug
tells make to build three different targets, and
make addconfig=kvm
tells make to create a variable named addconfig with the value kvm and
build the default target. And BTW, you or someone else reassured me
earlier in the thread that this is going to be needed for the kvm case
solely, so why are you inventing something generic now? :)
Michal
next prev parent reply other threads:[~2011-11-02 9:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 12:07 [PATCH] config: Add 'make kvmconfig' Sasha Levin
2011-10-27 12:12 ` Pekka Enberg
2011-10-27 12:37 ` Ingo Molnar
2011-10-27 12:51 ` Michal Marek
2011-10-27 13:34 ` Ingo Molnar
2011-10-27 14:11 ` Pekka Enberg
2011-10-27 14:32 ` Michal Marek
2011-10-27 15:05 ` Arnaud Lacombe
2011-10-27 15:19 ` Arnaud Lacombe
2011-10-27 15:30 ` Pekka Enberg
2011-10-27 18:05 ` Rabin Vincent
2011-10-27 20:46 ` Sasha Levin
2011-10-27 19:34 ` Sam Ravnborg
2011-10-28 7:03 ` Ingo Molnar
2011-10-28 7:23 ` Sasha Levin
2011-10-28 7:39 ` Ingo Molnar
2011-10-28 7:47 ` Sasha Levin
2011-10-28 7:52 ` Ingo Molnar
2011-10-28 7:52 ` Geert Uytterhoeven
2011-10-28 7:54 ` Ingo Molnar
2011-10-28 12:08 ` Matthias Schniedermeyer
2011-10-28 12:29 ` Ingo Molnar
2011-10-28 13:05 ` Matthias Schniedermeyer
2011-11-02 8:41 ` Ingo Molnar
2011-11-02 9:07 ` Michal Marek [this message]
2011-11-02 9:17 ` Ingo Molnar
2011-11-02 9:24 ` Michal Marek
2011-11-02 9:39 ` Ingo Molnar
2011-11-02 10:06 ` Pekka Enberg
2011-10-28 9:16 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB1084F.4020206@suse.cz \
--to=mmarek@suse.cz \
--cc=geert@linux-m68k.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ms@citd.de \
--cc=penberg@cs.helsinki.fi \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox