From: Jani Nikula <jani.nikula@intel.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
intel-gfx@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>,
linux-kbuild@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: drop -Wall and related disables from cflags as redundant
Date: Wed, 11 Oct 2023 10:31:38 +0300 [thread overview]
Message-ID: <871qe162ed.fsf@intel.com> (raw)
In-Reply-To: <CAKwvOdk-h_Bvz9iFN=fMMn14A=8iwoPgSS27iZVmy4auTXCYvA@mail.gmail.com>
On Tue, 10 Oct 2023, Nick Desaulniers <ndesaulniers@google.com> wrote:
> On Tue, Oct 10, 2023 at 1:50 AM Jani Nikula <jani.nikula@intel.com> wrote:
>> This is the simplest I could think of:
>>
>> # The following turn off the warnings enabled by -Wextra
>> ifeq ($(findstring 2, $(KBUILD_EXTRA_WARN)),)
>> KBUILD_CFLAGS += -Wno-missing-field-initializers
>> KBUILD_CFLAGS += -Wno-type-limits
>> KBUILD_CFLAGS += -Wno-shift-negative-value
>> endif
>> ifeq ($(findstring 3, $(KBUILD_EXTRA_WARN)),)
>> KBUILD_CFLAGS += -Wno-sign-compare
>> endif
>>
>> Masahiro, I'd like to get your feedback on which to choose,
>> unconditionally silencing the W=2/W=3 warnings for i915, or looking at
>> KBUILD_EXTRA_WARN.
>
> KBUILD_EXTRA_WARN looks better to me; otherwise they would be hidden
> forever (or nearly). Suffer some duplication, w/e.
Thanks, sent v2 with this [1].
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1697009258.git.jani.nikula@intel.com
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-10-11 7:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:34 [PATCH 0/2] drm/i915: align with W=1 warnings Jani Nikula
2023-10-06 12:34 ` [PATCH 1/2] drm/i915: drop -Wall and related disables from cflags as redundant Jani Nikula
2023-10-06 17:02 ` Nathan Chancellor
2023-10-06 21:12 ` Nick Desaulniers
2023-10-07 15:28 ` Masahiro Yamada
2023-10-09 16:38 ` Nathan Chancellor
2023-10-10 8:29 ` Jani Nikula
2023-10-10 8:49 ` [Intel-gfx] " Jani Nikula
2023-10-10 15:46 ` Nick Desaulniers
2023-10-11 7:31 ` Jani Nikula [this message]
2023-10-06 12:34 ` [PATCH 2/2] drm/i915: enable W=1 warnings by default Jani Nikula
2023-10-06 16:49 ` [Intel-gfx] " kernel test robot
2023-10-06 17:45 ` Nathan Chancellor
2023-10-10 8:33 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qe162ed.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=arnd@arndb.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox