Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: "Henrik Lindström" <henrik@lxm.se>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: nathan@kernel.org, nicolas.schier@linux.dev,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Makefile: remove dependency on archscripts for header installation
Date: Mon, 12 May 2025 17:55:53 +0200	[thread overview]
Message-ID: <8bd773107cf5a78359bcf03a0dcd2785@lxm.se> (raw)
In-Reply-To: <CAK7LNASYL6VCf_JgT_ks6ZObiR1xdB8HvV0XyYrWLrfYghtzbA@mail.gmail.com>

That was my attempt to explain why i wanted to make this change, but 
you're right that it's really just a small cleanup.

Will go again with a simpler message, thanks.

On 2025-05-12 14:23, Masahiro Yamada wrote:
> On Sun, May 11, 2025 at 12:34 AM Henrik Lindström <henrik@lxm.se> 
> wrote:
>> 
>> There doesn't seem to be any purpose behind this dependency, and it 
>> prevents
>> installing x86 and mips headers on non Linux systems. Doing so is 
>> useful when
>> building a cross compiler targetting Linux, which requires the header 
>> files.
>> 
>> Signed-off-by: Henrik Lindström <henrik@lxm.se>
>> ---
> 
> This clean-up makes sense.
> 
> However, I could not understand the commit description
> about the non-Linux systems.
> 
> In my understanding, archscripts is not required here
> regardless of whether it is a Linux or non-Linux system.
> 
> So, the following description sound good to me:
> 
>   archscripts has nothing to do with headers_install.
> 
> 
> Could you send v2 with the simplified commit log?
> 
> 
> 
> 
> 
> 
>>  Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Makefile b/Makefile
>> index b29cc321ffd9..0234faafe8f0 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1366,7 +1366,7 @@ PHONY += archheaders archscripts
>>  hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
>> 
>>  PHONY += headers
>> -headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders 
>> archscripts
>> +headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders
>>  ifdef HEADER_ARCH
>>         $(Q)$(MAKE) -f $(srctree)/Makefile HEADER_ARCH= 
>> SRCARCH=$(HEADER_ARCH) headers
>>  else
>> --
>> 2.39.5
>> 
> 
> 
> --
> Best Regards
> Masahiro Yamada

      reply	other threads:[~2025-05-12 16:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-10 15:32 [PATCH] Makefile: remove dependency on archscripts for header installation Henrik Lindström
2025-05-12 12:17 ` Nicolas Schier
2025-05-12 12:23 ` Masahiro Yamada
2025-05-12 15:55   ` Henrik Lindström [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd773107cf5a78359bcf03a0dcd2785@lxm.se \
    --to=henrik@lxm.se \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas.schier@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox