[PATCH] Makefile: remove dependency on archscripts for header installation

[PATCH] Makefile: remove dependency on archscripts for header installation

[Henrik Lindström]

There doesn't seem to be any purpose behind this dependency, and it prevents
installing x86 and mips headers on non Linux systems. Doing so is useful when
building a cross compiler targetting Linux, which requires the header files.

Signed-off-by: Henrik Lindström <henrik@lxm.se>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b29cc321ffd9..0234faafe8f0 100644
--- a/Makefile
+++ b/Makefile
@@ -1366,7 +1366,7 @@ PHONY += archheaders archscripts
 hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
 
 PHONY += headers
-headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders archscripts
+headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders
 ifdef HEADER_ARCH
 	$(Q)$(MAKE) -f $(srctree)/Makefile HEADER_ARCH= SRCARCH=$(HEADER_ARCH) headers
 else
-- 
2.39.5

Re: [PATCH] Makefile: remove dependency on archscripts for header installation

[Nicolas Schier]

On Sat, 10 May 2025, Henrik Lindström wrote:

> There doesn't seem to be any purpose behind this dependency, and it prevents
> installing x86 and mips headers on non Linux systems. Doing so is useful when
> building a cross compiler targetting Linux, which requires the header files.
> 
> Signed-off-by: Henrik Lindström <henrik@lxm.se>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index b29cc321ffd9..0234faafe8f0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1366,7 +1366,7 @@ PHONY += archheaders archscripts
>  hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
>  
>  PHONY += headers
> -headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders archscripts
> +headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders
>  ifdef HEADER_ARCH
>  	$(Q)$(MAKE) -f $(srctree)/Makefile HEADER_ARCH= SRCARCH=$(HEADER_ARCH) headers
>  else
> -- 
> 2.39.5
> 

Looks reasonable to me, thanks.

Reviewed-by: Nicolas Schier <n.schier@avm.de>

Re: [PATCH] Makefile: remove dependency on archscripts for header installation

[Masahiro Yamada]

On Sun, May 11, 2025 at 12:34 AM Henrik Lindström <henrik@lxm.se> wrote:
>
> There doesn't seem to be any purpose behind this dependency, and it prevents
> installing x86 and mips headers on non Linux systems. Doing so is useful when
> building a cross compiler targetting Linux, which requires the header files.
>
> Signed-off-by: Henrik Lindström <henrik@lxm.se>
> ---

This clean-up makes sense.

However, I could not understand the commit description
about the non-Linux systems.

In my understanding, archscripts is not required here
regardless of whether it is a Linux or non-Linux system.

So, the following description sound good to me:

  archscripts has nothing to do with headers_install.


Could you send v2 with the simplified commit log?






>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b29cc321ffd9..0234faafe8f0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1366,7 +1366,7 @@ PHONY += archheaders archscripts
>  hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
>
>  PHONY += headers
> -headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders archscripts
> +headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders
>  ifdef HEADER_ARCH
>         $(Q)$(MAKE) -f $(srctree)/Makefile HEADER_ARCH= SRCARCH=$(HEADER_ARCH) headers
>  else
> --
> 2.39.5
>


--
Best Regards
Masahiro Yamada

Re: [PATCH] Makefile: remove dependency on archscripts for header installation

[Henrik Lindström]

That was my attempt to explain why i wanted to make this change, but 
you're right that it's really just a small cleanup.

Will go again with a simpler message, thanks.

On 2025-05-12 14:23, Masahiro Yamada wrote:
> On Sun, May 11, 2025 at 12:34 AM Henrik Lindström <henrik@lxm.se> 
> wrote:
>> 
>> There doesn't seem to be any purpose behind this dependency, and it 
>> prevents
>> installing x86 and mips headers on non Linux systems. Doing so is 
>> useful when
>> building a cross compiler targetting Linux, which requires the header 
>> files.
>> 
>> Signed-off-by: Henrik Lindström <henrik@lxm.se>
>> ---
> 
> This clean-up makes sense.
> 
> However, I could not understand the commit description
> about the non-Linux systems.
> 
> In my understanding, archscripts is not required here
> regardless of whether it is a Linux or non-Linux system.
> 
> So, the following description sound good to me:
> 
>   archscripts has nothing to do with headers_install.
> 
> 
> Could you send v2 with the simplified commit log?
> 
> 
> 
> 
> 
> 
>>  Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Makefile b/Makefile
>> index b29cc321ffd9..0234faafe8f0 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1366,7 +1366,7 @@ PHONY += archheaders archscripts
>>  hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
>> 
>>  PHONY += headers
>> -headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders 
>> archscripts
>> +headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders
>>  ifdef HEADER_ARCH
>>         $(Q)$(MAKE) -f $(srctree)/Makefile HEADER_ARCH= 
>> SRCARCH=$(HEADER_ARCH) headers
>>  else
>> --
>> 2.39.5
>> 
> 
> 
> --
> Best Regards
> Masahiro Yamada