From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 2/5] kbuild: drop $(size_append) from cmd_zstd
Date: Mon, 10 Jan 2022 12:32:55 +0100 [thread overview]
Message-ID: <YdwZZ+1RQ5tcQZrt@buildd.core.avm.de> (raw)
In-Reply-To: <20220109181529.351420-2-masahiroy@kernel.org>
On Mon, Jan 10, 2022 at 03:15:26AM +0900, Masahiro Yamada wrote:
> The appended file size is only used by the decompressors, which some
> architectures support.
>
> As the comment "zstd22 is used for kernel compression" says, cmd_zstd22
> is used in arch/{mips,s390,x86}/boot/compressed/Makefile.
>
> On the other hand, there is no good reason to append the file size to
> cmd_zstd since it is used for other purposes.
>
> Actually cmd_zstd is only used in usr/Makefile, where the appended file
> size is rather harmful.
>
> The initramfs with its file size appended is considered as corrupted
> data, so commit 65e00e04e5ae ("initramfs: refactor the initramfs build
> rules") added 'override size_append := :' to make it no-op.
>
> As a conclusion, this $(size_append) should not exist here.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Reviewed-by: Nicolas Schier <n.schier@avm.de>
>
> scripts/Makefile.lib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index d1f865b8c0cb..5366466ea0e4 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -473,7 +473,7 @@ quiet_cmd_xzmisc = XZMISC $@
> # be used because it would require zstd to allocate a 128 MB buffer.
>
> quiet_cmd_zstd = ZSTD $@
> - cmd_zstd = { cat $(real-prereqs) | $(ZSTD) -19; $(size_append); } > $@
> + cmd_zstd = cat $(real-prereqs) | $(ZSTD) -19 > $@
>
> quiet_cmd_zstd22 = ZSTD22 $@
> cmd_zstd22 = { cat $(real-prereqs) | $(ZSTD) -22 --ultra; $(size_append); } > $@
> --
> 2.32.0
>
next prev parent reply other threads:[~2022-01-10 11:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 18:15 [PATCH 1/5] sh: rename suffix-y to suffix_y Masahiro Yamada
2022-01-09 18:15 ` [PATCH 2/5] kbuild: drop $(size_append) from cmd_zstd Masahiro Yamada
2022-01-10 11:32 ` Nicolas Schier [this message]
2022-01-09 18:15 ` [PATCH 3/5] kbuild: rename cmd_{bzip2,lzma,lzo,lz4,xzkern,zstd22} Masahiro Yamada
2022-01-10 11:33 ` Nicolas Schier
2023-06-23 14:45 ` Eugeniu Rosca
2023-07-19 19:09 ` Eugeniu Rosca
2023-07-22 16:08 ` Masahiro Yamada
2023-07-25 9:24 ` Eugeniu Rosca
2023-08-02 9:21 ` Masahiro Yamada
2023-08-11 11:25 ` Eugeniu Rosca
2022-01-09 18:15 ` [PATCH 4/5] arch: decompressor: remove useless vmlinux.bin.all-y Masahiro Yamada
2022-01-10 11:33 ` Nicolas Schier
2022-01-09 18:15 ` [PATCH 5/5] kbuild: add cmd_file_size Masahiro Yamada
2022-01-10 11:33 ` Nicolas Schier
2022-01-10 11:31 ` [PATCH 1/5] sh: rename suffix-y to suffix_y Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdwZZ+1RQ5tcQZrt@buildd.core.avm.de \
--to=n.schier@avm.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox