From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 4/5] arch: decompressor: remove useless vmlinux.bin.all-y
Date: Mon, 10 Jan 2022 12:33:29 +0100 [thread overview]
Message-ID: <YdwZiSAMs4PYR+S8@buildd.core.avm.de> (raw)
In-Reply-To: <20220109181529.351420-4-masahiroy@kernel.org>
On Mon, Jan 10, 2022 at 03:15:28AM +0900, Masahiro Yamada wrote:
> Presumably, arch/{parisc,s390,sh}/boot/compressed/Makefile copied
> arch/x86/boot/compressed/Makefile, but vmlinux.bin.all-y is useless
> here because it is the same as $(obj)/vmlinux.bin.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Reviewed-by: Nicolas Schier <n.schier@avm.de>
>
> arch/parisc/boot/compressed/Makefile | 14 ++++++--------
> arch/s390/boot/compressed/Makefile | 16 +++++++---------
> arch/sh/boot/compressed/Makefile | 12 +++++-------
> 3 files changed, 18 insertions(+), 24 deletions(-)
>
> diff --git a/arch/parisc/boot/compressed/Makefile b/arch/parisc/boot/compressed/Makefile
> index 2640f72d69ce..877a7099b5e1 100644
> --- a/arch/parisc/boot/compressed/Makefile
> +++ b/arch/parisc/boot/compressed/Makefile
> @@ -58,8 +58,6 @@ OBJCOPYFLAGS_vmlinux.bin := -R .comment -R .note -S
> $(obj)/vmlinux.bin: vmlinux FORCE
> $(call if_changed,objcopy)
>
> -vmlinux.bin.all-y := $(obj)/vmlinux.bin
> -
> suffix-$(CONFIG_KERNEL_GZIP) := gz
> suffix-$(CONFIG_KERNEL_BZIP2) := bz2
> suffix-$(CONFIG_KERNEL_LZ4) := lz4
> @@ -67,17 +65,17 @@ suffix-$(CONFIG_KERNEL_LZMA) := lzma
> suffix-$(CONFIG_KERNEL_LZO) := lzo
> suffix-$(CONFIG_KERNEL_XZ) := xz
>
> -$(obj)/vmlinux.bin.gz: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.gz: $(obj)/vmlinux.bin FORCE
> $(call if_changed,gzip)
> -$(obj)/vmlinux.bin.bz2: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.bz2: $(obj)/vmlinux.bin FORCE
> $(call if_changed,bzip2_with_size)
> -$(obj)/vmlinux.bin.lz4: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lz4: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lz4_with_size)
> -$(obj)/vmlinux.bin.lzma: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lzma: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lzma_with_size)
> -$(obj)/vmlinux.bin.lzo: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lzo: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lzo_with_size)
> -$(obj)/vmlinux.bin.xz: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.xz: $(obj)/vmlinux.bin FORCE
> $(call if_changed,xzkern_with_size)
>
> LDFLAGS_piggy.o := -r --format binary --oformat $(LD_BFD) -T
> diff --git a/arch/s390/boot/compressed/Makefile b/arch/s390/boot/compressed/Makefile
> index 8ea880b7c3ec..d04e0e7de0b3 100644
> --- a/arch/s390/boot/compressed/Makefile
> +++ b/arch/s390/boot/compressed/Makefile
> @@ -58,8 +58,6 @@ OBJCOPYFLAGS_vmlinux.bin := -O binary --remove-section=.comment --remove-section
> $(obj)/vmlinux.bin: vmlinux FORCE
> $(call if_changed,objcopy)
>
> -vmlinux.bin.all-y := $(obj)/vmlinux.bin
> -
> suffix-$(CONFIG_KERNEL_GZIP) := .gz
> suffix-$(CONFIG_KERNEL_BZIP2) := .bz2
> suffix-$(CONFIG_KERNEL_LZ4) := .lz4
> @@ -68,19 +66,19 @@ suffix-$(CONFIG_KERNEL_LZO) := .lzo
> suffix-$(CONFIG_KERNEL_XZ) := .xz
> suffix-$(CONFIG_KERNEL_ZSTD) := .zst
>
> -$(obj)/vmlinux.bin.gz: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.gz: $(obj)/vmlinux.bin FORCE
> $(call if_changed,gzip)
> -$(obj)/vmlinux.bin.bz2: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.bz2: $(obj)/vmlinux.bin FORCE
> $(call if_changed,bzip2_with_size)
> -$(obj)/vmlinux.bin.lz4: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lz4: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lz4_with_size)
> -$(obj)/vmlinux.bin.lzma: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lzma: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lzma_with_size)
> -$(obj)/vmlinux.bin.lzo: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lzo: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lzo_with_size)
> -$(obj)/vmlinux.bin.xz: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.xz: $(obj)/vmlinux.bin FORCE
> $(call if_changed,xzkern_with_size)
> -$(obj)/vmlinux.bin.zst: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.zst: $(obj)/vmlinux.bin FORCE
> $(call if_changed,zstd22_with_size)
>
> OBJCOPYFLAGS_piggy.o := -I binary -O elf64-s390 -B s390:64-bit --rename-section .data=.vmlinux.bin.compressed
> diff --git a/arch/sh/boot/compressed/Makefile b/arch/sh/boot/compressed/Makefile
> index a6808a403f4b..591125c42d49 100644
> --- a/arch/sh/boot/compressed/Makefile
> +++ b/arch/sh/boot/compressed/Makefile
> @@ -47,17 +47,15 @@ $(obj)/vmlinux: $(addprefix $(obj)/, $(OBJECTS)) FORCE
> $(obj)/vmlinux.bin: vmlinux FORCE
> $(call if_changed,objcopy)
>
> -vmlinux.bin.all-y := $(obj)/vmlinux.bin
> -
> -$(obj)/vmlinux.bin.gz: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.gz: $(obj)/vmlinux.bin FORCE
> $(call if_changed,gzip)
> -$(obj)/vmlinux.bin.bz2: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.bz2: $(obj)/vmlinux.bin FORCE
> $(call if_changed,bzip2_with_size)
> -$(obj)/vmlinux.bin.lzma: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lzma: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lzma_with_size)
> -$(obj)/vmlinux.bin.xz: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.xz: $(obj)/vmlinux.bin FORCE
> $(call if_changed,xzkern_with_size)
> -$(obj)/vmlinux.bin.lzo: $(vmlinux.bin.all-y) FORCE
> +$(obj)/vmlinux.bin.lzo: $(obj)/vmlinux.bin FORCE
> $(call if_changed,lzo_with_size)
>
> OBJCOPYFLAGS += -R .empty_zero_page
> --
> 2.32.0
>
next prev parent reply other threads:[~2022-01-10 11:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 18:15 [PATCH 1/5] sh: rename suffix-y to suffix_y Masahiro Yamada
2022-01-09 18:15 ` [PATCH 2/5] kbuild: drop $(size_append) from cmd_zstd Masahiro Yamada
2022-01-10 11:32 ` Nicolas Schier
2022-01-09 18:15 ` [PATCH 3/5] kbuild: rename cmd_{bzip2,lzma,lzo,lz4,xzkern,zstd22} Masahiro Yamada
2022-01-10 11:33 ` Nicolas Schier
2023-06-23 14:45 ` Eugeniu Rosca
2023-07-19 19:09 ` Eugeniu Rosca
2023-07-22 16:08 ` Masahiro Yamada
2023-07-25 9:24 ` Eugeniu Rosca
2023-08-02 9:21 ` Masahiro Yamada
2023-08-11 11:25 ` Eugeniu Rosca
2022-01-09 18:15 ` [PATCH 4/5] arch: decompressor: remove useless vmlinux.bin.all-y Masahiro Yamada
2022-01-10 11:33 ` Nicolas Schier [this message]
2022-01-09 18:15 ` [PATCH 5/5] kbuild: add cmd_file_size Masahiro Yamada
2022-01-10 11:33 ` Nicolas Schier
2022-01-10 11:31 ` [PATCH 1/5] sh: rename suffix-y to suffix_y Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdwZiSAMs4PYR+S8@buildd.core.avm.de \
--to=n.schier@avm.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox