From: Markus Elfring <Markus.Elfring@web.de>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andreas Grünbacher" <agruen@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH 2/6] genksyms: fix memory leak when the same symbol is read from *.symref file
Date: Fri, 3 Jan 2025 13:50:06 +0100 [thread overview]
Message-ID: <a7da70a4-19bf-4d53-a6c8-a5ddc422a199@web.de> (raw)
In-Reply-To: <20250103073046.2609911-2-masahiroy@kernel.org>
…
> +++ b/scripts/genksyms/parse.y
> @@ -482,12 +482,12 @@ enumerator_list:
> enumerator:
> IDENT
> {
> - const char *name = strdup((*$1)->string);
> + const char *name = (*$1)->string;
> add_symbol(name, SYM_ENUM_CONST, NULL, 0);
> }
…
I would find it safer and cleaner to separate such adjustments into another update step.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc5#n81
Will code transformation concerns be reconsidered any more?
Regards,
Markus
next prev parent reply other threads:[~2025-01-03 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 7:30 [PATCH 1/6] genksyms: fix memory leak when the same symbol is added from source Masahiro Yamada
2025-01-03 7:30 ` [PATCH 2/6] genksyms: fix memory leak when the same symbol is read from *.symref file Masahiro Yamada
2025-01-03 12:50 ` Markus Elfring [this message]
2025-01-03 7:30 ` [PATCH 3/6] genksyms: reduce the indentation in the for-loop in __add_symbol() Masahiro Yamada
2025-01-03 7:30 ` [PATCH 4/6] genksyms: refactor the return points " Masahiro Yamada
2025-01-03 7:30 ` [PATCH 5/6] genksyms: use generic macros for hash table implementation Masahiro Yamada
2025-01-03 7:30 ` [PATCH 6/6] genksyms: use uint32_t instead of unsigned long for calculating CRC Masahiro Yamada
2025-01-03 8:34 ` David Laight
2025-01-10 17:34 ` Masahiro Yamada
2025-01-03 11:56 ` [PATCH 1/6] genksyms: fix memory leak when the same symbol is added from source Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7da70a4-19bf-4d53-a6c8-a5ddc422a199@web.de \
--to=markus.elfring@web.de \
--cc=agruen@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox