From: Markus Elfring <Markus.Elfring@web.de>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andreas Grünbacher" <agruen@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH 1/6] genksyms: fix memory leak when the same symbol is added from source
Date: Fri, 3 Jan 2025 12:56:32 +0100 [thread overview]
Message-ID: <bef30d4b-8d43-4595-ac11-53526723ea34@web.de> (raw)
In-Reply-To: <20250103073046.2609911-1-masahiroy@kernel.org>
…
> +++ b/scripts/genksyms/genksyms.c
> @@ -239,6 +239,7 @@ static struct symbol *__add_symbol(const char *name, enum symbol_type type,
> "unchanged\n");
> }
> sym->is_declared = 1;
> + free_list(defn, NULL);
> return sym;
> } else if (!sym->is_declared) {
> if (sym->is_override && flag_preserve) {
…
Would you like to complete the data processing by using a corresponding goto chain?
Regards,
Markus
prev parent reply other threads:[~2025-01-03 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 7:30 [PATCH 1/6] genksyms: fix memory leak when the same symbol is added from source Masahiro Yamada
2025-01-03 7:30 ` [PATCH 2/6] genksyms: fix memory leak when the same symbol is read from *.symref file Masahiro Yamada
2025-01-03 12:50 ` Markus Elfring
2025-01-03 7:30 ` [PATCH 3/6] genksyms: reduce the indentation in the for-loop in __add_symbol() Masahiro Yamada
2025-01-03 7:30 ` [PATCH 4/6] genksyms: refactor the return points " Masahiro Yamada
2025-01-03 7:30 ` [PATCH 5/6] genksyms: use generic macros for hash table implementation Masahiro Yamada
2025-01-03 7:30 ` [PATCH 6/6] genksyms: use uint32_t instead of unsigned long for calculating CRC Masahiro Yamada
2025-01-03 8:34 ` David Laight
2025-01-10 17:34 ` Masahiro Yamada
2025-01-03 11:56 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bef30d4b-8d43-4595-ac11-53526723ea34@web.de \
--to=markus.elfring@web.de \
--cc=agruen@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox